This repository was archived by the owner on Feb 15, 2024. It is now read-only.
draft spec for join-addField#9
Open
elsdvlee wants to merge 17 commits into
Open
Conversation
Member
|
Please remove all .idea files and other temporary files like node_modules, etc. |
Collaborator
Author
|
I now remove .idea files, node_modules and added .gitignore |
bjdmeest
reviewed
Nov 15, 2023
| status: "Unofficial Draft", | ||
| publisher: "IDLab - Ghent University - imec", | ||
| authors: [ | ||
| "Ben De Meester", |
bjdmeest
reviewed
Nov 15, 2023
bjdmeest
reviewed
Nov 15, 2023
bjdmeest
reviewed
Nov 15, 2023
|
|
||
| The Range of a <dfn>parent logical source</dfn> property is a [Logical Source](https://kg-construct.github.io/rml-io/spec/docs/#defining-logical-sources) and describes the data source that supplies the additional data and is the right side of the join. | ||
|
|
||
| ### Join Conditions |
Member
There was a problem hiding this comment.
TODO: clarify that this is in fact exactly the same construct/definition as in RML-Core? Or are there differences?
bjdmeest
reviewed
Nov 15, 2023
| Els: can we also optionally declare a join function here, to allow not only equijoins (default) but also other joins | ||
| </aside> | ||
|
|
||
| ### Add Field |
Member
There was a problem hiding this comment.
TODO clarify that the reference expression of the parent logical source must then be used, and overwrites any conflicting reference expressions of the child logical source? (so you can then refer to the Alias)
bjdmeest
reviewed
Nov 15, 2023
|
|
||
| ### Add Field Alias | ||
|
|
||
| If the reference expression of the field of the parent logical source has a duplicated value in the child logical source, the **add field alias** property (`rml:addFieldAlias`) MUST be used instead of the **add field** property. |
Member
There was a problem hiding this comment.
Ah, this is different from my suggestion: overwrite by default. Up for discussion, whether we want the engine to throw an error asap vs be more lenient
bjdmeest
reviewed
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.