Repository navigation
Upgrade to Rails 7.2 - #83
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the kanaui mountable engine to Rails 7.2 and updates related runtime/CI constraints to match the new framework requirements and JRuby compatibility needs.
Changes:
- Require Ruby
>= 3.1.0and Rails~> 7.2in the gemspec. - Pin
i18nto~> 1.14.0to avoid fiber-based storage incompatibilities on certain runtimes. - Bump CI JRuby from
9.4.2.0to9.4.15.0.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
kanaui.gemspec |
Updates engine runtime requirements (Ruby min version) and Rails dependency to 7.2. |
Gemfile |
Adds an i18n version pin intended to avoid known fiber-related breakages. |
.github/workflows/ci.yml |
Updates JRuby version used in CI to a release that exposes Fiber.current. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dimension requests trigger a parser bug that mangles CASE...END expressions, returning 500 errors. Workaround: expand dimension requests to filter-only requests client-side and stitch results together. Filter-only requests don't trigger the bug. Related to Rails 7.2 upgrade with updated MariaDB JDBC drivers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
pierre
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the engine to Rails 7.2.
rails ~> 7.2in the gemspecSee killbill/killbill-admin-ui#655 for the corresponding kaui engine upgrade.
JRuby CI fix (i18n / Fiber.current)
CI on
jruby-9.4.2.0failed during boot with:Root cause: i18n 1.15.x switched
I18n.configto fiber-based storage. The original 1.15.0 report (ruby-i18n/i18n#735) covered theFiber[:i18n_config]call breaking CRuby < 3.2; 1.15.1/1.15.2 reworked that butI18n::Config#initializestill callsFiber.current. JRuby 9.4.2.0 doesn't expose a publicFiber.current(only the internal__current__; the public alias was added in a later 9.4.x release), so any i18n >= 1.15.0 fails at boot on that runtime.This PR therefore also:
i18nto~> 1.14.0(1.14.x has no fiber code path, and satisfies activesupport 7.2'si18n >= 1.6, < 2) — matching the existing pins in kaui and kaui-standaloneFiber.current) — matching kaui's CI