Repository navigation
Migrate kanaui stylesheets to Design System 2026 color tokens - #85
Merged
Merged
Conversation
Replace all hardcoded hex and keyword colors (99 rules across kanaui.css and reports.css) with var(--kb-*) tokens from killbill-assets-ui 1.1.0, and pin the gemspec dependency accordingly. Also folds in the pending reports.css chart-color conversion (steelblue/blue -> primary tokens). Refs killbill/technical-support#316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs killbill/technical-support#316.
kanaui.cssandreports.css) withvar(--kb-*)design tokens fromkillbill-assets-ui1.1.0 (grays → neutral/onSurface/surface/outline, blues → primary, status colors → error/success/warning semantics).reports.csschart-color conversion (steelblue/blue → primary tokens).killbill-assets-ui >= 1.1.0in the gemspec (the tokens only exist from that version).assets:precompilein kaui-standalone: zero engine hexes left in the compiled bundle.Note: this branch is cut from
jruby10-upgrade, so the diff also includes the 2 pending commits from that branch (JRuby 10 CI + json pin).