Repository navigation
Bump CI to JRuby 10 - #20
Merged
Merged
Conversation
Bump jruby-9.4.15.0 -> jruby-10.0.6.0 (LTS line) in the CI matrix. Part of Phase 1 of the JRuby 10 upgrade (Rails stays ~> 7.2 for now). Validated locally: bundle install resolves cleanly under real JRuby 10.1.1.0/JDK21. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pierre
approved these changes
Sep 8, 2026
Defense-in-depth fix, part of the same root-cause investigation as the CI failures fixed in killbill-kpm-ui and killbill-email-notifications-ui (see their jruby10-upgrade branch commits for full details). This repo currently resolves json 2.x thanks only to an INCIDENTAL transitive constraint (rubocop's own `json ~> 2.3` dependency in whatever version bundler happens to resolve here) - not a real guarantee. rubocop 1.90.0 (released 2026-08-24) loosened its own json dependency to `json >= 2.3` (no upper bound), so this repo's unpinned `gem 'json'` could silently start resolving json 3.x on any future bundle install (Gemfile.lock isn't committed in this repo), exactly as already happened in killbill-kpm-ui and killbill-email-notifications-ui once json 3.0.0/3.0.1 were published (2026-09-07/08). json 3.0 dropped the quirks_mode keyword that ActiveSupport::JSON.encode still passes to JSON.generate (not fixed until Rails 8.1.0), raising ArgumentError on any #to_json call - including killbill-client's model classes, used throughout this engine. Pinned `gem 'json', '~> 2.21'` explicitly rather than relying on rubocop's transitive constraint. Verified: bundle install resolves json (2.21.2); test suite passes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Phase 1 of the JRuby 10 upgrade (Rails stays ~> 7.2 for now). Bumps CI from jruby-9.4.15.0 to jruby-10.0.6.0 (LTS line). Validated locally:
bundle installresolves cleanly under real JRuby 10.1.1.0/JDK21.