Repository navigation
Add Kill Bill Design System 2026 tokens (assets 1.1.0) - #21
Merged
Merged
Conversation
tungleduyxyz
requested review from
piyushkalasariya
and
a balanced review from Copilot
October 4, 2026 08:50
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The Bootstrap bridge is ineffective, several foreground pairs fail accessibility contrast, and DataTables duplicates a primitive color.
Review effort: Balanced
Findings: 4
Open (5)
What changed in this PR
Adds shared Kill Bill Design System 2026 tokens and migrates existing stylesheets to consume them.
Changes:
- Introduces color, typography, semantic, and legacy tokens.
- Establishes deterministic stylesheet ordering and Bootstrap mappings.
- Converts legacy styles, documents theming, and releases version 1.1.0.
| File | Description |
|---|---|
README.md |
Documents token usage and theming rules. |
lib/assets/version.rb |
Bumps the gem to 1.1.0. |
app/assets/stylesheets/assets/tokens.css |
Defines the design-system tokens. |
app/assets/stylesheets/assets/theme.css |
Replaces hardcoded theme colors. |
app/assets/stylesheets/assets/jquery_datatables.css |
Updates the selected-row color. |
app/assets/stylesheets/assets/element.css |
Migrates legacy styling to tokens. |
app/assets/stylesheets/assets/datatable.css |
Tokenizes legacy table colors. |
app/assets/stylesheets/assets/common.css |
Makes asset ordering explicit. |
app/assets/stylesheets/assets/bootstrap_and_overrides.css |
Adds the Bootstrap token bridge. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Add --kb-primary-500-rgb channel token and reference it from jquery_datatables.css instead of duplicating the raw RGB triplet. - Clarify the Bootstrap bridge comment: Bootstrap 5.0.2 component rules use compiled hex, so the --bs-* vars serve var(--bs-*) consumers only; stock component theming lives in theme.css. - Annotate the two Figma-sourced pairs that fall below WCAG AA (on-primary on primary-400, on-warning on warning-500) as pending design review. - Fix the surface token shorthand typo in README.md.
Contributor
Author
|
Addressed the Copilot review in 490306a:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Refs killbill/technical-support#316. Land this first — all engine PRs depend on these tokens.
tokens.css— the single source of truth for the Kill Bill Design System 2026: 6 color primitive scales, semantic tokens (primary/surface/onSurface/outline/status/disabled/tag-containers), 16 Inter text styles asfont: var(--kb-…)tokens, and a--kb-legacy-*section preserving old-theme values exactly.common.css(explicit requires instead ofrequire_tree; tokens first).--bs-*Bootstrap bridge moved tobootstrap_and_overrides.css, right afterbootstrap.min.cssso it wins the cascade.theme.css,element.css,datatable.css: ~80 hardcoded colors → tokens; stale sourceMappingURL comments and acalc(unquote(...))artifact removed.Verified via
assets:precompilein kaui-standalone (tokens defined once, bridge ordering correct).