Repository navigation
fix(aws-transform): stop blocking native Windows in custom workflow platform check - #213
Open
thalisantunes wants to merge 1 commit into
Open
thalisantunes wants to merge 1 commit into
thalisantunes wants to merge 1 commit into
Conversation
…latform check atx custom is supported on native Windows (Windows Terminal and PowerShell) per the AWS Transform custom getting-started docs; only atx ct is not yet supported there. Replace the WSL-only block and the uname probe with a platform note, update the troubleshooting row, and bump aws-transform to 2.8.1. Fixes kirodotdev#198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #198
steering/workload-custom.mdhad a "0. Platform Check" that stopped native Windows users and sent them to WSL. The official AWS Transform custom docs say native Windows is supported:Source: https://docs.aws.amazon.com/transform/latest/userguide/custom-get-started.html
The only Windows limitation is
atx ct(continuous modernization), a separate workflow.The check was also unreliable. It ran
uname -sand treated "command not found" as native Windows, butunamedoes not exist in PowerShell, so it blocked a supported environment because the probe itself was missing.Changes:
workload-custom.md: replace the WSL-only block and theunameprobe with a short platform note (native Windows and WSL supported;atx ctnot yet supported on native Windows).workload-custom-troubleshooting.md: the "Windows not supported" row now says onlyatx ctis unsupported on native Windows.POWER.md: version 2.8.0 -> 2.8.1, following the pattern of earlier aws-transform fixes. Happy to drop this if maintainers bump versions themselves.Verification:
atx --version,atx updateandatx custom def list --jsonrun on native Windows with PowerShell 7 (CLI 3.13.0), and that removing the block let the custom workflow run.workload-custom.md(for example the Linux/macOS install hints for the AWS CLI) were not reviewed for Windows wording and are left unchanged.