Support glob expressions for xml reports files #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or-shachar
force-pushed
the
multiple-xmls-pr
branch
from
f58b7dc to
89d9ca8
Compare
alexec
reviewed
Jan 5, 2023
Collaborator
alexec
left a comment
alexec
left a comment
There was a problem hiding this comment.
I'd like to avoid --flags and just parse stdin.
Could we just change it to read many files from stdin?
junit2html < reports/junit*.xml reports/coverage*.xml > report.html
Author
|
I understand your preference... unfortunately it doesn't really work with multiple files. If you think this can work anyways would love to hear your suggestion. |
Collaborator
|
Ah. Ok. Can we change the flag to be just -f? |
Author
|
sure thing |
Collaborator
|
Heads up, I've moved repo. |
psturc
added a commit
to psturc/junit2html
that referenced
this pull request
Nov 13, 2023
fix: remove errors from list of passed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP but this is to resolve #3
I want to clean it up so it won't be one long main function. Split to data collection and data printer.