Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Nov 18, 2025

Tiny misspell fix

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.80%. Comparing base (51e2b5d) to head (6eb064b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/pipelines/tekton/pipelines_provider.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3201      +/-   ##
==========================================
+ Coverage   53.91%   59.80%   +5.89%     
==========================================
  Files         162      162              
  Lines       14763    14763              
==========================================
+ Hits         7959     8829     +870     
+ Misses       5876     4884     -992     
- Partials      928     1050     +122     
Flag Coverage Δ
e2e-tests 41.50% <0.00%> (+8.09%) ⬆️
integration-tests 54.50% <0.00%> (?)
unit-tests 45.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@creydr creydr changed the title Fix: misspell and enable misspell check for golangci-lint Fix typo Nov 20, 2025
@creydr
Copy link
Member Author

creydr commented Nov 20, 2025

/cc @gauron99

@knative-prow knative-prow bot requested a review from gauron99 November 20, 2025 08:57
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2025
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@creydr
Copy link
Member Author

creydr commented Nov 20, 2025

@gauron99 can you recheck? I rebased after #3200 was in

Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit cf796c6 into knative:main Nov 20, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants