Skip to content

Enforce go-licenses v1.0.0 #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matzew wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enforce go-licenses v1.0.0 #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -918,7 +918,7 @@ function run_kntest() {
# Run go-licenses to check for forbidden licenses.
function check_licenses() {
# Check that we don't have any forbidden licenses.
go_run github.com/google/go-licenses@v1.6.0 \
go_run github.com/google/go-licenses@v1.0.0 \
Copy link
Contributor

@skonto skonto Sep 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going back? 🤔 Ok I see:

In v1.1, we made a breaking change of no longer supporting non go modules managed projects

Tekton has it (and go license have breaking changes) but is it a failure or warning? Does it happen on the CI too or is it local? 🤔

Copy link
Contributor

@dsimansk dsimansk Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are warning in various CI logs, but I haven't found exit status 1.

Copy link
Contributor

@cardil cardil Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to use some non-gomod deps?

/hold

Copy link

@codysoyland codysoyland Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to use some non-gomod deps?

Note the errors which indicate go-licenses is expecting Go standard library code to be Go Modules (Package crypto/aes does not have module info.), which seems to be a bug.

check "${REPO_ROOT_DIR}/..." || \
{ echo "--- FAIL: go-licenses failed the license check"; return 1; }
}
Expand Down
2 changes: 1 addition & 1 deletion test/unit/update_deps_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func TestUpdateDeps(t *testing.T) {
contains("Checking licenses"),
contains("Removing unwanted vendor files"),
contains("👻 go mod tidy"),
contains("👻 go run github.com/google/go-licenses@v1.6.0 check"),
contains("👻 go run github.com/google/go-licenses@v1.0.0 check"),
contains("👻 go mod download -x"),
},
}, {
Expand Down