Remove trailing period from Styleguide section in examples and tests#108
Open
JohnAlbin wants to merge 2 commits into
Open
Remove trailing period from Styleguide section in examples and tests#108JohnAlbin wants to merge 2 commits into
JohnAlbin wants to merge 2 commits into
Conversation
JohnAlbin
force-pushed
the
spec-trailing-period
branch
from
95364ea to
b09469b
Compare
Contributor
Author
|
Typo in my original test. Fixed! |
JohnAlbin
force-pushed
the
spec-trailing-period
branch
from
b09469b to
a8ec218
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's fine that we should remove an optional trailing space from the Styleguide reference. But I don't see how it's useful to show them in the spec and the examples.
In this PR, I've removed the trailing space from the spec and all examples. But I've added a test that confirms that the optional trailing period is stripped.
Do we need to add a note in the spec for KSS parsers that they should strip trailing periods from Styleguide references?