UIEXT-3150: Fix API error in WebUI reader framework (shown in Eclipse)#84
Open
UIEXT-3150: Fix API error in WebUI reader framework (shown in Eclipse)#84
Conversation
The API changes, since the return type changed, so it is incompatible with call sites expecting the earlier version UIEXT-3150 (WebUI-Migration Excel Reader)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an API error in the WebUI reader framework by adding proper Javadoc and updating API filter configurations to address API tooling complaints about a method override.
Changes:
- Added
@since 5.11Javadoc to thecomputeStatemethod override - Updated API filter to correctly handle the method signature change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TransformationParametersStateProviders.java | Added Javadoc with @since tag to document API change in computeState method |
| .api_filters | Updated filter ID and added message arguments to properly suppress API warnings for non-public API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
enplotz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was likely built before the baseline bump, but merged afterwards.
Without the since-version I get this in Eclipse 2025-12 with 5.10 as baseline API:
