Zig parser: fix 6 finder bugs#110
Conversation
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
|
Merge-order note (not a defect — flagging for landing order) The zig parser here was authored against a different base than #85 ( Also: this PR reclassifies camelCase |
…lias (BUG-NEW 3,17,41) Local-only finder-fixes-54 (base master 368b559). TDD; 5 tests in the new tests/parsers/zig/test_call_graph_builder_u*.py. Judge (vs prepared recommendation, independent re-derivation from raw): AGREE / SHIP-AS-IS. CM-B builtin pre-check scoped SAME-FILE (judge-confirmed: no global cross-file fallback; genuine-builtin non-link pinned by a negative test). Combined parser suite: 70 passed, 10 skipped. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 4294ffe24e0814bc2668f1f6c46c3874de56b01e)
…n/container-methods (BUG-NEW 16,26,37) Local-only finder-fixes-54. 7 new tests. [37] fixed grammar node-type keys (variable_declaration + struct/enum/union/opaque_declaration, members=function_declaration) so container methods extract as C.m; [16] first identifier as fn name; [26] anchored test classification. Cross-unit: the [37] fix changes the call-graph edge target to the now-correct qualified id m.zig:C.m -> updated 2 test_call_graph_builder_u13 assertions (judge-verified legitimate, not a weakening). Judge: AGREE / SHIP-AS-IS. (Follow-up: dead _extract_struct_methods left for a separate cleanup.) Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 1aae27a79420beb4ab1ad2f2c064124c221ec26d)
|
Rebased onto origin/master (post-release #133 / Wave 1). Conflicts resolved by UNION — both this PR's fix and the Wave-1 parser fixes are preserved; no Wave-1 change reverted (independently judge-verified). Force-pushed with --force-with-lease. zig parser tests green (35). Per the staging-stack resolution, the stale camelCase |
1 participant
Zig parser: fix 6 finder bugs
Local-only branch
pr/zig-parseroff master368b559. One of a coordinated 7-PR set fixing parser/reachability bugs found by the OpenAnt finder. File-disjoint from the other 6 PRs (no merge collision; any order).Addresses 6 finder bug-ids (6 distinct fixes; 0 ride a same-PR canonical).
Bugs fixed
[3]zig-local-type-dispatch (zig/namespace_dispatch) — same defect as BUG-044 (zig leg) (characterized but unmerged; this lands it on master)[16]zig-extraction_gap-147 (zig/extraction_gap) — genuinely-new (no prior logged entry)[17]zig-builtin_filter_leak-234 (zig/builtin_filter_leak) — genuinely-new (no prior logged entry)[26]zig-metadata-265-test (zig/metadata_correctness) — genuinely-new (no prior logged entry)[37]zig-extraction_gap-106-structmethod (zig/extraction_gap) — same defect as BUG-095/096 (characterized but unmerged; this lands it on master)[41]zig-dataflow_loss-298-alias (zig/dataflow_loss) — genuinely-new (no prior logged entry)Dedup status (independent + judge, from raw)
4 genuinely-new · 0 duplicate-of-curated (cross-ref above) · 2 covered-by-curated · 0 intra-PR-duplicate. All re-confirmed STILL PRESENT on pristine master
368b559(git show 368b559:).Tests
Verified GREEN in isolation off pristine
368b559: 12 passed (tests/parsers/zig/). New per-bug regression tests. (Notest_<lang>_schema_completeness.py/test_callgraph_symmetry.pyparser-infra in this PR — a follow-up; master has none either.)Notes
🤖 Generated with Claude Code