C/C++ parser: fix 11 finder bugs#114
Open
gadievron wants to merge 4 commits into
Open
Conversation
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
Collaborator
Author
|
Merge-order note (not a defect — flagging for landing order) Most delicate overlap in the set. |
…eck (BUG-NEW 13) Local-only finder-fixes-54 (base master 368b559). TDD; 6 tests in the new tests/parsers/c/test_call_graph_builder_u*.py. Judge (vs prepared recommendation, independent re-derivation from raw): AGREE / SHIP-AS-IS. CM-B builtin pre-check scoped SAME-FILE (judge-confirmed: no global cross-file fallback; genuine-builtin non-link pinned by a negative test). Combined parser suite: 70 passed, 10 skipped. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit ef1a3f91f163547a7652132f65613bb1be56c973)
…/operator/template/ns (BUG-NEW 14,15,32,33,35,39,40) Local-only finder-fixes-54 (base 368b559). 8 tests. struct_specifier/union_specifier branches mirror class_specifier (closes [32] AND the [38] static-call dup — VERIFIED: Helper::compute resolves); ctor/dtor on unqualified leaf; lambda_expression; operator_name; template args in func_id (g<int>!=g); namespace-qualifier vs class-qualifier (namespaced free fn class_name=None). Judge+probe: AGREE / SHIP-AS-IS. Full parser suite 131 passed, 10 skipped. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit e360860ceac539a3d1df0f5068faf560e3e9c6c2)
…G-NEW 29) Local-only finder-fixes-54 (base master 368b559). The C extractor produces func_data['is_inline'] but create_unit dropped it from unit metadata (and the parallel generate_analyzer_output dropped 'isInline'). Carry it in both, matching the is_static/is_exported convention. Adds RF-1 field-contract guard tests/parsers/c/test_c_schema_completeness.py: an explicit producer-key -> dotted-unit-location MAP (+ snake->camel analyzer map) that round-trips each contracted field, so future drops fail automatically; plus a self-check pinning the drift-prone key in the map. 5 tests; c+php parser suites pass. Judge (vs prepared recommendation): AGREE / SHIP-AS-IS; RF-1 realized as the sound field-contract MAP (not a key-superset). Independent+judge concurred. Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit 5eece7512f6872d878039e4866a32d13d4311a86)
…erited dispatch Adds the local-decl type-inference machinery that was MISSING for these two deferred bugs (judge-confirmed last time they couldn't be a resolver tweak). 10 tests; full c suite 50 passed (no regression of the 9 committed c bugs). [51] member-dispatch (sound, same-file): preserve the receiver (_extract_call_name_and_receiver); new _extract_local_var_types (varname->type from declaration nodes incl. pointer/init/reference declarators); methods_by_class index; receiver-type-aware _resolve_member_call resolves w.compute()/w->compute() to Type::compute when the receiver's local-declared type defines it same-file — else FALLS BACK to base-name resolution (no false edge when type unknown). [30] virtual/inherited dispatch (static-declared-type FLOOR + inheritance walk): function_extractor now extracts base classes (_extract_base_classes walks base_class_clause -> class_bases index); _resolve_member_call does a cycle-guarded BFS UP the base chain, resolving to the first ancestor that defines the method. Base* b; b->compute() links ONLY Base::compute (the static type's method) — derived overrides are the DOCUMENTED non-goal (over-approximation = false edges). Override stops the walk; unknown/no-definer -> None. Precision negatives all pass (unknown receiver, free fn unchanged, two-class disambiguation, override-stops-walk, no-ancestor, inheritance cycle). Independent + judge verified SOUND from raw; no false edge introduced vs prior behavior. One pre-existing same-file same-name-cross-namespace mislink is unchanged by this fix (documented optional follow-up). go/python tree changes are separate (already committed). Local-only; not pushed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit e55be766db832831a716c3c97509f9af9d103d88)
Collaborator
Author
|
Rebased onto origin/master (post-release #133 / Wave 1). Conflicts resolved by UNION — both this PR's fix and the Wave-1 parser fixes are preserved; no Wave-1 change reverted (independently judge-verified). Force-pushed with --force-with-lease. C parser tests green (63). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C/C++ parser: fix 11 finder bugs
Local-only branch
pr/c-parseroff master368b559. One of a coordinated 7-PR set fixing parser/reachability bugs found by the OpenAnt finder. File-disjoint from the other 6 PRs (no merge collision; any order).Addresses 12 finder bug-ids (11 distinct fixes; 1 ride a same-PR canonical).
Bugs fixed
[13]c-builtin_filter_leak-234 (c/builtin_filter_leak) — genuinely-new (no prior logged entry)[14]c-metadata-260-dtor (c/metadata_correctness) — genuinely-new (no prior logged entry)[15]c-metadata-259-ctor (c/metadata_correctness) — genuinely-new (no prior logged entry)[29]c-schema_field_drift-237-isinline (c/schema_field_drift) — genuinely-new (no prior logged entry)[30]c-namespace_dispatch-265-virtual (c/namespace_dispatch) — genuinely-new (no prior logged entry)[32]c-metadata-386-structmember (c/metadata_correctness) — genuinely-new (no prior logged entry)[33]c-extraction_gap-368-lambda (c/extraction_gap) — genuinely-new (no prior logged entry)[35]c-extraction_gap-148-operator (c/extraction_gap) — genuinely-new (no prior logged entry)[38]c-namespace_dispatch-386-staticcall (c/namespace_dispatch) — duplicate of [32] in this PR; closed by the same fix (no separate change)[39]c-extraction_gap-152-template (c/extraction_gap) — genuinely-new (no prior logged entry)[40]c-metadata-418-nsfreefunc (c/metadata_correctness) — genuinely-new (no prior logged entry)[51]c-namespace_dispatch-246-membercall (c/namespace_dispatch) — genuinely-new (no prior logged entry)Dedup status (independent + judge, from raw)
11 genuinely-new · 0 duplicate-of-curated (cross-ref above) · 0 covered-by-curated · 1 intra-PR-duplicate. All re-confirmed STILL PRESENT on pristine master
368b559(git show 368b559:).Tests
Verified GREEN in isolation off pristine
368b559: 50 passed (tests/parsers/c/). New per-bug regression tests + atest_<lang>_schema_completeness.pyfield-contract guard.Notes
🤖 Generated with Claude Code