Open
Conversation
…apira # Conflicts: # src/main/java/com/example/springlabs/configuration/StoreConfiguration.java # src/main/java/com/example/springlabs/repositories/CategoryRepository.java # src/main/java/com/example/springlabs/repositories/CategoryRepositoryImpl.java # src/main/java/com/example/springlabs/repositories/ProductRepository.java # src/main/java/com/example/springlabs/repositories/ProductRepositoryImpl.java # src/main/java/com/example/springlabs/repositories/UserRepository.java # src/main/java/com/example/springlabs/repositories/UserRepositoryImpl.java # src/main/java/com/example/springlabs/services/CategoryService.java # src/main/java/com/example/springlabs/services/ProductService.java # src/main/java/com/example/springlabs/services/UserService.java
xd6d
requested changes
Dec 6, 2023
Collaborator
xd6d
left a comment
xd6d
left a comment
There was a problem hiding this comment.
And we have no implementation for creating sub-category
| @Transactional | ||
| public Category addCategory(Category category) { | ||
| categoryRepository.save(category); | ||
| return category; |
Collaborator
There was a problem hiding this comment.
You can simplify it just to return categoryRepository.save(category);
Collaborator
There was a problem hiding this comment.
and for some reason there is no line formatting
| long id = saveParseId(stringId); | ||
| return categoryRepository.updateCategory(id, categoryFromDto, getSubcategories(categoriesNames)) | ||
| .orElseThrow(() -> new CategoryNotFoundException(CATEGORY_ID_NOT_FOUND.formatted(stringId))); | ||
| getCategoryByName(categoriesNames); |
xd6d
reviewed
Dec 7, 2023
Comment on lines
+93
to
+97
| Optional<Category> category = categoryService.addCategory(categoryDtoMapper.createCategoryFromDto(categoryDto), urlComponents); | ||
| if (category.isEmpty()) { | ||
| throw new CategoryNotFoundException( | ||
| CATEGORY_NAME_NOT_FOUND.formatted("Category is empty")); | ||
| } else return categoryDtoMapper.createDto(category.get()); |
Collaborator
There was a problem hiding this comment.
IMHO, this logic is better to move to the CategoryService and leave here only return categoryDtoMapper.createDto(categoryService.addCategory(categoryDtoMapper.createCategoryFromDto(categoryDto), urlComponents));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.