Add numpy to EdgeDraw demo deps so the docs WASM embed works - #322
Merged
Conversation
The EdgeDraw reference page embeds demos/edgedraw.py as a marimo WASM notebook. Its get_adjacency_matrix() cell imports numpy at runtime, but numpy was missing from the PEP 723 dependency list, so the Pyodide sandbox never installed it and the cell broke. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The EdgeDraw reference docs page embeds a live marimo WASM (Pyodide) notebook —
demos/edgedraw.py, loaded viadocs/assets/javascripts/demo-embed.js. That notebook has a cell callingwidget.get_adjacency_matrix(), andEdgeDraw.get_adjacency_matrix()does a runtimeimport numpy(wigglystuff/edge_draw.py). But the demo's PEP 723# /// scriptdependency list omitted numpy, so the Pyodide sandbox never installed it and the cell broke with a numpy import error.Change
Add
numpy==2.4.3to the demo's PEP 723 dependency block, placed betweenmarimoand thewigglystuffpin to match the convention used by other demos (dimensions.py,cube_widget.py, …).Verification
uv run marimo check demos/edgedraw.pypasses.🤖 Generated with Claude Code