fix: add Mozambique and Angola validators#154
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the library's international coverage by adding robust validation and formatting capabilities for key identification numbers from Angola and Mozambique. It ensures that both personal and tax identification documents from these countries can be accurately processed, alongside a minor but important fix for TypeScript type exports. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new validators for Angola (BI and NIF) and Mozambique (BI and NUIT), along with their corresponding tests and registration in the library. Feedback identifies a critical need for case normalization in the cleaning phase to prevent validation failures on lowercase inputs. Additionally, improvements were suggested for the accuracy of documentation comments regarding identifier formats and the alphabetical ordering of entries in the README.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Adds support for Mozambican and Angolan identification number validators.
Angola (
ao)000204688CA010).Mozambique (
mz)110504162779A).107705694).Changes
src/ao/bi.tsandsrc/ao/nif.tswith full validators, formatters and spec files.src/mz/bi.tsandsrc/mz/nuit.tswith full validators, formatters and spec files.AOandMZinsrc/index.ts(stdnum map, personValidators, entityValidators).README.mdtable with the new country entries.Validatorto useexport typeto eliminate TypeScript warnings.