Skip to content

fix: add Mozambique and Angola validators#154

Open
frankdors wants to merge 6 commits intokoblas:mainfrom
tribemd-assist:main
Open

fix: add Mozambique and Angola validators#154
frankdors wants to merge 6 commits intokoblas:mainfrom
tribemd-assist:main

Conversation

@frankdors
Copy link
Copy Markdown

Summary

Adds support for Mozambican and Angolan identification number validators.

Angola (ao)

  • BI – Bilhete de Identidade (Angola Identity Card): 14-character number composed of 9 digits, 2 uppercase letters, and 3 digits (e.g. 000204688CA010).
    • NIF – Número de Identificação Fiscal (Angola Tax Identification Number): accepts either a 10-digit company number or a 14-character individual number matching the BI format.

Mozambique (mz)

  • BI – Bilhete de Identidade (Mozambican National Identity Document): 13-character number with 12 digits followed by 1 uppercase letter (e.g. 110504162779A).
    • NUIT – Número Único de Identificação Tributária (Mozambican Tax Identification Number): 9-digit number with a check digit validated via a modulo-11 algorithm (e.g. 107705694).

Changes

  • Added src/ao/bi.ts and src/ao/nif.ts with full validators, formatters and spec files.
    • Added src/mz/bi.ts and src/mz/nuit.ts with full validators, formatters and spec files.
    • Registered AO and MZ in src/index.ts (stdnum map, personValidators, entityValidators).
    • Updated README.md table with the new country entries.
    • Fixed re-export of Validator to use export type to eliminate TypeScript warnings.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the library's international coverage by adding robust validation and formatting capabilities for key identification numbers from Angola and Mozambique. It ensures that both personal and tax identification documents from these countries can be accurately processed, alongside a minor but important fix for TypeScript type exports.

Highlights

  • New Validators for Angola: Added comprehensive validation and formatting logic for Angolan Bilhete de Identidade (BI) and Número de Identificação Fiscal (NIF).
  • New Validators for Mozambique: Introduced validation and formatting for Mozambican Bilhete de Identidade (BI) and Número Único de Identificação Tributária (NUIT).
  • Library Integration: Integrated the new Angolan and Mozambican validators into the main library index, making them accessible via stdnum, personValidators, and entityValidators.
  • Documentation Update: Updated the README.md file to include the newly supported Angolan and Mozambican identification types.
  • TypeScript Type Export Fix: Corrected the re-export of the Validator type in src/index.ts to use export type to resolve TypeScript warnings.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new validators for Angola (BI and NIF) and Mozambique (BI and NUIT), along with their corresponding tests and registration in the library. Feedback identifies a critical need for case normalization in the cleaning phase to prevent validation failures on lowercase inputs. Additionally, improvements were suggested for the accuracy of documentation comments regarding identifier formats and the alphabetical ordering of entries in the README.

Comment thread src/ao/bi.ts Outdated
Comment thread src/ao/nif.ts Outdated
Comment thread src/mz/bi.ts Outdated
Comment thread README.md
Comment thread src/ao/nif.ts Outdated
Comment thread src/mz/bi.ts Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants