Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/building/pages/build-with-args.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ It is possible to link:https://github.com/containers/buildah/blob/main/docs/buil

== Using an arguments file

The {ProductName} buildah tasks accept link:https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/buildah.yaml#L78[`BUILD_ARGS` parameter] that allows passing build arguments to the underlying `buildah` command through `--build-arg-file` flag. To enable this, make the following changes to the PipelineRuns under the `.tekton/` directory:
The {ProductName} buildah tasks accept a `BUILD_ARGS_FILE` parameter that allows passing build arguments to the underlying `buildah` command through the `--build-arg-file` flag. For details, see the link:https://github.com/konflux-ci/build-definitions/tree/main/task/buildah/[buildah task documentation]. To enable this, make the following changes to the PipelineRuns under the `.tekton/` directory:

. Create a build args file in your repository. This should contain lines of build arguments in the form of *arg=value*.
. Define a `build-args-file` Pipeline parameter (if not already present) in `.spec.pipelineSpec.params` to accept the passed-in build arguments.
Expand Down Expand Up @@ -53,7 +53,7 @@ spec:

== Setting arguments in the pipeline parameters

The {ProductName} buildah tasks accept link:https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/buildah.yaml#L74[`BUILD_ARGS` parameter] that allows passing build arguments to the underlying `buildah` command through `--build-arg` flag. To enable this, make the following changes to the PipelineRuns under the `.tekton/` directory:
The {ProductName} buildah tasks accept a `BUILD_ARGS` parameter that allows passing build arguments to the underlying `buildah` command through the `--build-arg` flag. For details, see the link:https://github.com/konflux-ci/build-definitions/tree/main/task/buildah/[buildah task documentation]. To enable this, make the following changes to the PipelineRuns under the `.tekton/` directory:

. Define a `build-args` Pipeline parameter (if not already present) in `.spec.pipelineSpec.params` to accept the passed-in build arguments.

Expand Down
4 changes: 2 additions & 2 deletions modules/building/pages/creating-secrets.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ type: kubernetes.io/dockerconfigjson
The {ProductName} UI links image pull secrets to either selected or all components
specific service accounts `build-pipeline-$COMPONENT_NAME`
- No pipeline YAML changes are required.
- Tasks like the buildah task will use this secret automatically when pulling images from `quay.io`. (https://github.com/konflux-ci/build-definitions/blob/main/task/buildah-oci-ta/0.3/buildah-oci-ta.yaml in volumes)
- Tasks like the buildah task will use this secret automatically when pulling images from `quay.io`. For details, see the link:https://github.com/konflux-ci/build-definitions/tree/main/task/buildah-oci-ta/[buildah-oci-ta task documentation].

* **Manual Secret Creation**
. **Link Secret To SA**
Expand Down Expand Up @@ -229,7 +229,7 @@ stringData:

== Referencing Secrets in a Containerfile

Sometimes you might need to reference a secret directly in your Containerfile. For example, if your build uses cryptographic parameters stored in secrets, you can use the link:https://github.com/konflux-ci/build-definitions/blob/main/task/buildah-oci-ta/0.4/README.md[`ADDITIONAL_SECRET` parameter] to customize encryption in your Containerfile.
Sometimes you might need to reference a secret directly in your Containerfile. For example, if your build uses cryptographic parameters stored in secrets, you can use the `ADDITIONAL_SECRET` parameter to customize encryption in your Containerfile. For details, see the link:https://github.com/konflux-ci/build-definitions/tree/main/task/buildah-oci-ta/[buildah-oci-ta task documentation].

.Procedure

Expand Down
2 changes: 1 addition & 1 deletion modules/building/pages/hermetic-builds.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
====
* Hermetic builds disable network access, so a build with dependencies outside of its Git repository--including supported languages--might fail. To prevent this, or to pull in dependencies from a package manager for one of the xref:prefetching-dependencies.adoc#supported-languages[supported languages], follow the instructions in xref:prefetching-dependencies.adoc[Prefetching the package manager dependencies for the hermetic build].
+
Similarly, with a link:https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.1/buildah.yaml[Buildah] task for a non-Java application, when you set the `*hermetic*` parameter to `true`, youre isolating the build from the network, which restricts it to building only from dependencies listed in your Git repository.
Similarly, with a link:https://github.com/konflux-ci/build-definitions/tree/main/task/buildah/[Buildah] task for a non-Java application, when you set the `hermetic` parameter to `true`, you're isolating the build from the network, which restricts it to building only from dependencies listed in your Git repository.

* Do not add these parameters to the link:https://github.com/burrsutter/partner-catalog-stage/blob/e2ebb05ba8b4e842010710898d555ed3ba687329/.tekton/partner-catalog-stage-wgxd-pull-request.yaml#L87[`**pipelineSpec.params**`] section, as it should always display the default values for hermetic builds.
====
Expand Down
Loading