Skip to content

Fix Bash not showing 'Waiting for input' when approval needed (#33)#40

Merged
kosinal merged 2 commits intomasterfrom
feature/37-fix-bash-notifications
Mar 4, 2026
Merged

Fix Bash not showing 'Waiting for input' when approval needed (#33)#40
kosinal merged 2 commits intomasterfrom
feature/37-fix-bash-notifications

Conversation

@kosinal
Copy link
Copy Markdown
Owner

@kosinal kosinal commented Mar 4, 2026

Summary

  • Register PermissionRequest and PostToolUse hook events to accurately detect when a tool needs user approval vs. is auto-approved
  • PermissionRequest sets status to "waiting" (fires only when permission dialog is shown), PostToolUse resets to "running" (fires after tool completes)
  • Fixes Not showing running after bash prompt submitted #33 without the false-positive regression from the previous approach of adding Bash to INTERACTIVE_TOOLS

Test plan

  • Run npm test — all 96 tests pass including 6 new tests
  • Run npm run lint — no errors
  • Start dashboard, trigger a Bash command needing approval → dashboard shows "Waiting for input"
  • Auto-approved Bash command → dashboard stays "Running"
  • Interactive tools (Write, Edit, AskUserQuestion) still show "Waiting for input"

kosinal and others added 2 commits March 4, 2026 09:46
Remove Bash from INTERACTIVE_TOOLS so PreToolUse events for Bash
commands set status to "running" instead of "waiting", preventing
spurious "Waiting for input" notifications for auto-approved commands.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kosinal kosinal merged commit 6750b5a into master Mar 4, 2026
6 checks passed
@kosinal kosinal deleted the feature/37-fix-bash-notifications branch March 4, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not showing running after bash prompt submitted

1 participant