Fix notifications not firing for PermissionRequest waiting states#52
Merged
Fix notifications not firing for PermissionRequest waiting states#52
Conversation
The NOTIFY_TOOLS whitelist in checkAndNotify only included interactive tools (ExitPlanMode, AskUserQuestion, Write, Edit, NotebookEdit), so PermissionRequest events for tools like Bash never triggered browser notifications despite correctly showing "waiting" status. Removed the NOTIFY_TOOLS filter since the state machine already correctly determines when user input is needed. Fixes #51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTIFY_TOOLSallowlist from the dashboard's browser notification logic that was preventing notifications forPermissionRequesteventsExitPlanMode,AskUserQuestion,Write,Edit,NotebookEdit— so permission prompts for tools likeBashnever triggered browser notifications despite correctly showing "waiting" statusTest plan
NOTIFY_TOOLSis removed and notification fires for all waiting transitionsFixes #51
🤖 Generated with Claude Code