Conversation
…lision (#162) Co-authored-by: mdblocker <mdaltonblocker@gmail.com>
solivella
reviewed
May 27, 2026
solivella
left a comment
solivella
left a comment
Collaborator
There was a problem hiding this comment.
This is looking great. Thank you, @1beb. Left a couple of comments. There is a more general issue I didn't see a good place to mark: If we split the oth category, we should be careful to also modify the race.margin object.
| #' @param table.surnames,table.first,table.middle Optional user dictionaries. | ||
| #' @return A named list with elements \code{first}, \code{middle}, and \code{last}. | ||
| #' @keywords internal | ||
| load_name_dictionaries <- function(namesToUse, name_source = NULL, year = "2020", |
Collaborator
There was a problem hiding this comment.
My sense is that we're moving away from the old census.surname path, but the defaults here make that path the standard. Better to use name_source="mixed" and census.surname=NULL?
| #' \code{.predict_race_new} fits a version of BISG which uses a new, augmented | ||
| #' surname dictionary, and can also accommodate the use of first and middle | ||
| #' name information. Finally, \code{.predict_race_me} fits a fully Bayesian Improved | ||
| #' name information. \code{.predict_race_me} fits a fully Bayesian Improved |
Collaborator
There was a problem hiding this comment.
There should also be a short description of eBISG here. @noahdasanaike?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.