Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for updating lifecycle settings on sandboxes through a new update_life_cycle method. The implementation moves lifecycle parameters from query parameters to request body fields, aligning with API best practices.
Key Changes
- Added
update_life_cycle()method to the Sandbox class for programmatic lifecycle management - Refactored API to accept lifecycle settings in request body instead of query parameters
- Extended
ServiceListItemmodel to include lifecycle information
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/openapi.json | Removed lifecycle query parameters and added lifecycle field to ServiceListItem schema |
| koyeb/sandbox/utils.py | Added DeploymentsApi client and updated return type signature |
| koyeb/sandbox/sandbox.py | Implemented update_life_cycle method and updated API client calls |
| koyeb/api/models/service_list_item.py | Added lifecycle field with serialization support |
| koyeb/api/docs/ServicesApi.md | Updated documentation to remove lifecycle query parameters |
| koyeb/api/docs/ServiceListItem.md | Documented new lifecycle field |
| koyeb/api/api/services_api.py | Removed lifecycle query parameters from update_service methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.