Add variadic template support to min, max, any/all_finite/nan/inf functions and moved them out of the 'internal' namespace. #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took functions is/any/all_finite/nan/inf from 'internal' namespace. It is really usefull to have them avaliable because constexpr imlementation of corresponding functions in std avaliable only from c++23 Reimlemeted any/all_ variants using variadic template arguments
Added overload of min and max functions that accept variadic number of arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I am really like your compile-time math functions library and would like to contribute some functionality I would be happy to have in it.
First of all I moved is/any/all_finite/nan/inf out of the 'internal' namespace and added support of variadic argument count to them, as well as to min and max functions.
I really tried to follow your coding style, but I apologize in advance if something is wrong written (especially in doxygen comments, I've never worked with them).