KTOR-9496 Docs for JavScript ES module support#796
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR updates Ktor's digest authentication implementation to RFC 7616 compliance, reworking the example code to use plaintext passwords with dynamic multi-algorithm digest computation, extending the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ffa19fc to
52fe914
Compare
52b05f9 to
b5425f1
Compare
| #### JS target updated for ES modules | ||
|
|
||
| Ktor test infrastructure now targets the [ES2015](https://262.ecma-international.org/6.0/) standard to verify compatibility | ||
| with modern JavaScript environments and upcoming changes in Kotlin’s default JavaScript target. This ensures compatibility | ||
| with ES module–based setups and keeps Ktor aligned with the evolving Kotlin/JS ecosystem. | ||
|
|
||
| #### Node.js ES modules support in `ktor-network` | ||
|
|
||
| The `ktor-network` module now works correctly in Node.js projects that use ES modules. This improves compatibility with | ||
| modern bundlers when targeting both Node.js and browser environments and avoids issues caused by Node.js-specific | ||
| modules (such as `net`) being included in browser builds. |
There was a problem hiding this comment.
I'm sorry for not providing a proper description for the issues. I think we can omit details and write something like this instead of two sub-sections:
We've fixed problems making it impossible to use ktor-network and all dependent modules with ES modules enabled. We've also updated our test infrastructure to target ES2015 and ES modules to prevent possible regressions.
These links might be helpful:
There was a problem hiding this comment.
Thanks, updated the section now.
b5425f1 to
b888039
Compare
b888039 to
2d8d43b
Compare
Add a what's new entry for the following issues:
KTOR-9350 JS: Make ES2015 the default target for tests
KTOR-7659 Make ktor-network compatible with ES modules for nodejs