-
Notifications
You must be signed in to change notification settings - Fork 53
Update .spec.configuration API changes #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: obaydullahmhs <[email protected]>
|
Visit the preview URL for this PR (updated for commit 237cab6): https://kubedb-v2-hugo--pr840-reconfig-vddkg1cf.web.app (expires Thu, 05 Feb 2026 15:55:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 25884160 | Triggered | Generic Password | f670872 | docs/guides/clickhouse/concepts/clickhouse.md.bak | View secret |
| 25884161 | Triggered | Username Password | f670872 | docs/guides/cassandra/concepts/cassandra.md.bak | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
ArnobKumarSaha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats remaining here ?
docs/examples/clickhouse/reconfigure/ch-reconfigure-ops-with-secret.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
docs/examples/pgbouncer/reconfigure/pbops-reconfigure-apply.yaml
Outdated
Show resolved
Hide resolved
|
make sure those too
|
|
https://github.com/kubedb/docs/blame/master/tandby what is this? Do we need this? |
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
|
File: There's a line like: For Maybe it can be rewritten as: Any thought on this? |
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
docs/guides/memcached/custom-configuration/using-config-file.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
| configuration: | ||
| secretName: mssql-custom-config | ||
| authSecret: | ||
| kind: Secret | ||
| name: mssqlserver-auth | ||
| configSecret: | ||
| name: mssqlserver-custom-config | ||
| name: mssql-admin-cred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep
mssqlserver-custom-config
mssqlserver-auth
| - configuration: | ||
| + secretName: new-custom-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove - / +
| kind: Redis | ||
| metadata: | ||
| name: sample-redis | ||
| namespace: databases | ||
| spec: | ||
| version: 6.0.20 | ||
| deletionPolicy: WipeOut | ||
| configSecret: # configure Redis to use password for authentication | ||
| name: redis-config | ||
| configuration: # configure Redis to use password for authentication | ||
| secretName: redis-config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why redis in proxysql?
No description provided.