Skip to content

Conversation

@obaydullahmhs
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 17, 2026

Visit the preview URL for this PR (updated for commit 237cab6):

https://kubedb-v2-hugo--pr840-reconfig-vddkg1cf.web.app

(expires Thu, 05 Feb 2026 15:55:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943

Signed-off-by: Bonusree <[email protected]>
@gitguardian
Copy link

gitguardian bot commented Jan 20, 2026

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
25884160 Triggered Generic Password f670872 docs/guides/clickhouse/concepts/clickhouse.md.bak View secret
25884161 Triggered Username Password f670872 docs/guides/cassandra/concepts/cassandra.md.bak View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@ArnobKumarSaha ArnobKumarSaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats remaining here ?

Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Bonusree and others added 8 commits January 21, 2026 17:28
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: Bonusree <[email protected]>
@HiranmoyChowdhury
Copy link
Member

make sure those too

  • when you change the directory name in example, change the kubectl apply /path/.../<directory name> too.
  • make sure the CR from guide similar to the CR from example.

@obaydullahmhs
Copy link
Member Author

https://github.com/kubedb/docs/blame/master/tandby

what is this? Do we need this?

@refat75
Copy link
Contributor

refat75 commented Jan 23, 2026

File: docs/guides/mariadb/reconfigure/cluster/index.md
Line: 374

There's a line like:

If everything goes well, `KubeDB` Enterprise operator will update the `configSecret` of `MariaDB` object.

For applyConfig we don't update the configSecret of DB object. Rather we update the configuration.inline field of DB object.

Maybe it can be rewritten as:

If everything goes well, `KubeDB` operator will update the `configuration` field  of `MariaDB` object.

Any thought on this?
@souravbiswassanto @sheikh-arman @Neaj-Morshad-101

Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: souravbiswassanto <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Signed-off-by: Bonusree <[email protected]>
Comment on lines +34 to +38
configuration:
secretName: mssql-custom-config
authSecret:
kind: Secret
name: mssqlserver-auth
configSecret:
name: mssqlserver-custom-config
name: mssql-admin-cred
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep
mssqlserver-custom-config
mssqlserver-auth

Comment on lines +226 to +227
- configuration:
+ secretName: new-custom-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove - / +

Comment on lines +51 to +59
kind: Redis
metadata:
name: sample-redis
namespace: databases
spec:
version: 6.0.20
deletionPolicy: WipeOut
configSecret: # configure Redis to use password for authentication
name: redis-config
configuration: # configure Redis to use password for authentication
secretName: redis-config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why redis in proxysql?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants