Skip to content

add cypress coverage for manage columns behaviour in hardware conf table#2732

Open
Philip-Carneiro wants to merge 2 commits into
kubeflow:mainfrom
Philip-Carneiro:test/manage-columns-cypress-coverage
Open

add cypress coverage for manage columns behaviour in hardware conf table#2732
Philip-Carneiro wants to merge 2 commits into
kubeflow:mainfrom
Philip-Carneiro:test/manage-columns-cypress-coverage

Conversation

@Philip-Carneiro
Copy link
Copy Markdown
Contributor

Description

Added cypress coverage to Manage Columns in Hardware Configuration Table

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Copy Markdown
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Cypress coverage for manage columns! A few items to clean up around DRY and redundant assertions.

@manaswinidas
Copy link
Copy Markdown
Contributor

Informational — library coverage gap

9 of the 16 tests here (toggle, cancel, persist, restore-defaults, search) exercise ManageColumnsModal / useManageColumns behavior from mod-arch-shared. The mod-arch-library repo has test infrastructure (both Cypress and unit) but zero coverage for these components today.

These tests are valuable as the only coverage that currently exists, so not blocking on this — but ideally this coverage should move upstream as unit/component tests in mod-arch-library, leaving only a smoke test + the app-specific latency filter interaction tests here.

Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
@Philip-Carneiro Philip-Carneiro force-pushed the test/manage-columns-cypress-coverage branch from d16a5a3 to 68cccf2 Compare June 2, 2026 09:38
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manaswinidas. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants