add cypress coverage for manage columns behaviour in hardware conf table#2732
add cypress coverage for manage columns behaviour in hardware conf table#2732Philip-Carneiro wants to merge 2 commits into
Conversation
manaswinidas
left a comment
There was a problem hiding this comment.
Thanks for adding Cypress coverage for manage columns! A few items to clean up around DRY and redundant assertions.
|
Informational — library coverage gap 9 of the 16 tests here (toggle, cancel, persist, restore-defaults, search) exercise These tests are valuable as the only coverage that currently exists, so not blocking on this — but ideally this coverage should move upstream as unit/component tests in mod-arch-library, leaving only a smoke test + the app-specific latency filter interaction tests here. |
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
d16a5a3 to
68cccf2
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Description
Added cypress coverage to Manage Columns in Hardware Configuration Table
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes