Implement Secure Port Forwarding#1128
Open
aojea wants to merge 7 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
Signed-off-by: Antonio Ojea <aojea@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements secure, bidirectional TCP port forwarding (tunneling) over WebSockets for Kubeflow Workspaces. This allows users to securely access workspace resources (like SSH or other container ports) without exposing raw ports over the internet.
WorkspaceKindPortto allow to expose TCP ports in addition to the existing HTTP ones (port forwarding is only allowed on TCP types). This is required because for HTTP the controller creates an Istio VirtualService to route web traffic from the browser through the Istio Ingress Gateway directly to the container but it breaks TCP only traffic. Setting the Service to TCP allows to forward it.connectverb on the workspaces Kubernetes resource. Access is strictly enforced at the API layer via Delegated SubjectAccessReviews (SAR).closes: #23