Skip to content

Conversation

@steled
Copy link
Contributor

@steled steled commented Nov 20, 2025

What this PR does / why we need it:

This PR enhances the Helm deployment script to support multiple values.yaml files as separate arguments instead of a single file.
Previously, the script only allowed one values file. With this change, users can pass any number of values files, which Helm will apply in order (later files override earlier ones).
This improves flexibility for complex deployments where configuration is split across multiple files (e.g., base, overrides, secrets).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • Argument parsing was refactored:
    • DEPLOY_TYPE remains the first argument.
    • CHART_FOLDER and DEPLOY_STACK are now the last two arguments.
    • All arguments in between are treated as values files.
  • Validation ensures at least one values file exists and all provided files are real paths.
  • Helm command now expands to multiple --values flags using an array for safe quoting.
  • IAP configuration check was updated to scan all provided values files for oidc_issuer_url.

Does this PR introduce a user-facing change?:

Helm deployment script now supports passing multiple values.yaml files as separate arguments:
Old usage:
  ./kubermatic-deploy.sh master values.yaml charts/ logging

New usage:
  ./kubermatic-deploy.sh master base.yaml override.yaml secrets.yaml charts/ logging

Order matters: later files override earlier ones.

- add support for multiple helm values files

Signed-off-by: Stephan <[email protected]>
Refactor IAP deployment check to verify oidc_issuer_url in all values files.

Signed-off-by: Stephan <[email protected]>
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Nov 20, 2025
@kubermatic-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dharapvj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link

Hi @steled. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 20, 2025
@steled steled changed the title Patch 1 Refactor kubermatic-deploy.sh for argument handling Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants