Skip to content

add a script to verify PRR has all the sections #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+790 −2
Closed

add a script to verify PRR has all the sections #5685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ NOCOLOR:=\\033[0m

##@ KEPs

.PHONY: update-toc verify-toc verify-metadata
.PHONY: update-toc verify-toc verify-metadata verify-prr-template

update-toc: ## Updates KEP Table of Contents.
${REPO_ROOT}/hack/update-toc.sh
Expand All @@ -36,6 +36,9 @@ verify-toc: ## Verifies the Table of Contents is in the correct format.
verify-metadata: ## Verifies the KEP metadata is valid yaml.
${REPO_ROOT}/hack/verify-kep-metadata.sh

verify-prr-template: ## Verifies KEPs have complete Production Readiness Review sections.
${REPO_ROOT}/hack/verify-prr-template.py

##@ Verify

.PHONY: add-verify-hook verify verify-boilerplate verify-build verify-golangci-lint verify-go-mod verify-shellcheck verify-spelling
Expand All @@ -50,7 +53,7 @@ verify: ## Runs all verification tests.
${REPO_ROOT}/hack/verify.sh

# TODO(lint): Uncomment verify-shellcheck once we finish shellchecking the repo.
verify: tools verify-boilerplate verify-build verify-golangci-lint verify-go-mod #verify-shellcheck ## Runs verification scripts to ensure correct execution
verify: tools verify-boilerplate verify-build verify-golangci-lint verify-go-mod verify-prr-template #verify-shellcheck ## Runs verification scripts to ensure correct execution

verify-boilerplate: ## Runs the file header check
${REPO_ROOT}/hack/verify-boilerplate.sh
Expand Down
Loading