feat(waf): AwsWebAcl#1847
Closed
vandjelk wants to merge 79 commits into
Closed
Conversation
Contributor
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
vandjelk
force-pushed
the
waf/aws/webacl
branch
3 times, most recently
from
7904e5e to
6d2e5a4
Compare
vandjelk
force-pushed
the
waf/aws/webacl
branch
4 times, most recently
from
629dfe8 to
51562c2
Compare
vandjelk
force-pushed
the
waf/aws/webacl
branch
3 times, most recently
from
ed6389f to
f0c1329
Compare
vandjelk
force-pushed
the
waf/aws/webacl
branch
2 times, most recently
from
d07ac8f to
4e034d9
Compare
Replace custom isNotFoundError function with standard awsmeta.IsNotFound utility
- Use ListWebACLs to find WebACL by name instead of extracting ID from ARN - Store loaded *wafv2types.WebACL in state for use across actions - Remove extractIdFromArn helper function - Update deleteWebAcl to fallback to ListWebACLs when WebACL not in state
…Type, EvaluationWindowSec, CustomKeys)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)