feat: Add Azure Managed Redis CRD types #1874
Conversation
Control PanelHi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
|
dushanpantic
left a comment
There was a problem hiding this comment.
In my opinion, the API design needs to go back to the drawing board.
The offered clustering policies and SKUs no longer map to what we have used in our previous Redis offerings.
The closes thing is NoCluster for instance, and OSSCluster for cluster.
Also, we are unable to set shards/replicas manually (beside 1 via High availability), and they are now part of the selected Azure SKU.
Perhaps offering a separate instance vs cluster resource no longer makes sense.
AzureManagedRedisInstance uses NoCluster policy (single-endpoint, non-clustered mode) — add it to the KCP CRD validation enum.
|
Design decisions made in this PR:
This follows the established project convention - every other provider (AWS, GCP, Azure
Renamed to match the project-wide convention used by all other Redis CRDs (AwsRedisTier,
|
Part of #1834 | Design: #1845
Adds the three new CRDs for Azure Managed Redis support:
AzureManagedRedisInstance(SKR) -NoClustermodeAzureManagedRedisCluster(SKR) -OSSClustermodeAzureManagedRedis(KCP) — new provider-specific CRD, does not extendRedisInstanceIncludes generated deepcopy, CRD YAMLs, RBAC roles, and
azureManagedRedisfeature flag.