Skip to content

feat: Add Azure Managed Redis CRD types #1874

Open
stekik wants to merge 9 commits into
kyma-project:mainfrom
stekik:feature/amr-types
Open

feat: Add Azure Managed Redis CRD types #1874
stekik wants to merge 9 commits into
kyma-project:mainfrom
stekik:feature/amr-types

Conversation

@stekik
Copy link
Copy Markdown
Contributor

@stekik stekik commented May 12, 2026

Part of #1834 | Design: #1845

Adds the three new CRDs for Azure Managed Redis support:

  • AzureManagedRedisInstance (SKR) - NoCluster mode
  • AzureManagedRedisCluster (SKR) -OSSCluster mode
  • AzureManagedRedis (KCP) — new provider-specific CRD, does not extend RedisInstance

Includes generated deepcopy, CRD YAMLs, RBAC roles, and azureManagedRedis feature flag.

@stekik stekik requested a review from a team as a code owner May 12, 2026 08:50
@hyperspace-insights
Copy link
Copy Markdown
Contributor

Control Panel

Hi, I'm an AI-powered Review Bot that helps you with summarizing and reviewing pull requests.
To interact with me, just use the following actions:

  • 📝 Summarize PR
  • 🔍 Review
  • 🗑️ Delete all bot comments and reviews

Copy link
Copy Markdown
Contributor

@dushanpantic dushanpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, the API design needs to go back to the drawing board.

The offered clustering policies and SKUs no longer map to what we have used in our previous Redis offerings.
The closes thing is NoCluster for instance, and OSSCluster for cluster.

Also, we are unable to set shards/replicas manually (beside 1 via High availability), and they are now part of the selected Azure SKU.

Perhaps offering a separate instance vs cluster resource no longer makes sense.

Comment thread api/cloud-resources/v1beta1/azuremanagedredisinstance_types.go Outdated
@stekik stekik force-pushed the feature/amr-types branch from b717ce7 to 7a18909 Compare May 18, 2026 08:51
@stekik
Copy link
Copy Markdown
Contributor Author

stekik commented May 18, 2026

Design decisions made in this PR:

  1. Keeping two SKR CRDs (AzureManagedRedisInstance / AzureManagedRedisCluster)

This follows the established project convention - every other provider (AWS, GCP, Azure
legacy) splits instance and cluster into separate CRDs.

  1. sku renamed to redisTier

Renamed to match the project-wide convention used by all other Redis CRDs (AwsRedisTier,
GcpRedisTier, AzureRedisTier).

  1. Full redisTier enum sourced directly from armredisenterprise/v3 SDK

@stekik stekik requested a review from ngrkajac May 18, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants