Skip to content

Conversation

@pjohennecken-WTK
Copy link

@pjohennecken-WTK pjohennecken-WTK commented Nov 24, 2025

Adds a driver for the Badgerd SDWire3 based device SD Card multiplexer.

This device is very similar to the already existing SDWire by Tizen.

See: https://badgerd.nl/sdwirec/

Description

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

@pjohennecken-WTK pjohennecken-WTK force-pushed the feat/add-sdwire3-driver branch 4 times, most recently from 0282d3b to 42af1ca Compare December 1, 2025 13:14
@Emantor
Copy link
Member

Emantor commented Dec 1, 2025

I how far does the SDWire3 differ from the SDWire and why can't the existing support for SDWire not be reused?

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 42.10526% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.1%. Comparing base (70f6150) to head (42af1ca).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/usbsdwire3driver.py 45.4% 24 Missing ⚠️
labgrid/resource/udev.py 43.7% 18 Missing ⚠️
labgrid/remote/exporter.py 0.0% 7 Missing ⚠️
labgrid/remote/client.py 0.0% 3 Missing ⚠️
labgrid/resource/remote.py 71.4% 2 Missing ⚠️
labgrid/resource/suggest.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1781     +/-   ##
========================================
- Coverage    45.2%   45.1%   -0.1%     
========================================
  Files         172     173      +1     
  Lines       13569   13702    +133     
========================================
+ Hits         6136    6184     +48     
- Misses       7433    7518     +85     
Flag Coverage Δ
3.10 45.1% <42.1%> (-0.1%) ⬇️
3.11 45.1% <42.1%> (-0.1%) ⬇️
3.12 45.1% <42.1%> (-0.1%) ⬇️
3.13 45.1% <42.1%> (-0.1%) ⬇️
3.14 45.1% <42.1%> (-0.1%) ⬇️
3.9 45.1% <42.1%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onkelpit
Copy link

onkelpit commented Dec 1, 2025

It is not using a FTDI for the configuration. It's using the sdwire version of Badgered https://github.com/Badger-Embedded/sdwire-cli.

Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good.

USBSDWire3Device
~~~~~~~~~~~~~~~~
A :any:`USBSDWire3Device` resource describes a Tizen
`SD Wire device <https://web.archive.org/web/20240121081917/https://wiki.tizen.org/SDWire>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to an SDWire3 website, not the original sdwire website from tizen.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Fixed that

Signed-off-by: Peter Johennecken <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants