feat(FR-1448): allow user to select multi agents when creating multi-node session #4309

nowgnuesLee · 2025-09-19T08:17:17Z

This PR adds support for selecting multiple agents when launching a session, available for Backend.AI manager version 25.15.0 and above.

Key changes:

Modified AgentSelect component to handle multiple agent selection
Updated agent selection logic in ResourceAllocationFormItems to support multi-agent mode
Added special handling for the "auto" option in multi-select mode
Implemented proper agent_list generation in session creation payload
Added 'multi-agents' feature detection for manager version 25.16.0+
Changed agent default value from string to array format ['auto']
Removed restrictions that previously disabled cluster settings when a specific agent was selected

for testing, using test server which supports multi node session(like dogbowl)
Prior to version 25.16.0, it must behave identically to the existing version.

how to test:

single mode
- Please verify that the agent_list is sent as a string[] when using multi-agents.
multi mode
- Please verify that the agent_list is being passed as a string array when using multi-agents.

Checklist:

Documentation
Minium required manager version: 25.16.0
Specific setting for review
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

nowgnuesLee · 2025-09-19T08:17:34Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR enables multi-agent selection when creating multi-node sessions for Backend.AI manager version 25.15.0 and above. It transforms the agent selection from a single dropdown to a multi-select component while maintaining backward compatibility.

Added 'multi-agents' feature detection for manager version 25.15.0+
Modified AgentSelect component to support multiple agent selection with special "auto" handling
Updated session creation payload logic to properly handle agent arrays and cluster size requirements

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/lib/backend.ai-client-esm.ts	Added feature flag detection for multi-agents support
react/src/pages/SessionLauncherPage.tsx	Updated session creation payload logic and default agent value format
react/src/components/ResourceAllocationFormItems.tsx	Modified form to support multi-agent selection and removed cluster restrictions
react/src/components/AgentSelect.tsx	Enhanced component to handle multiple selection with auto option logic

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

react/src/components/AgentSelect.tsx

react/src/pages/SessionLauncherPage.tsx

github-actions · 2025-09-19T08:22:06Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.46%	517/11601
🔴	Branches	3.61%	297/8237
🔴	Functions	2.59%	92/3552
🔴	Lines	4.43%	503/11348

Test suite run success

118 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 7ea5f0e

ironAiken2

please resolve the conflicts :)

yomybaby

Code improvements

1. ResourceAllocationFormItems.tsx

Improved code readability by removing spread operator and passing props directly
mode and labelRender props are now more explicitly defined

2. SessionLauncherPage.tsx

Simplified array handling by replacing Array.isArray() check with _.castArray()
Better utilization of lodash utility function for cleaner code

agatha197

please resolve the conflicts. and is there any test node? you can reply it in jira comment or teams.

agatha197

It needs to handle resource allocation also when user set multiple agent.

react/src/components/SessionFormItems/ResourceAllocationFormItems.tsx

react/src/hooks/useStartSession.tsx

agatha197

Please update description tooltip also.

resources/i18n/ko.json

agatha197

LGTM

ironAiken2

How about removing the check icon?

react/src/components/AgentSelect.tsx

yomybaby

LGTM

react/src/components/AgentSelect.tsx

ironAiken2

LGTM

graphite-app · 2025-11-19T06:50:13Z

Merge activity

Nov 19, 6:50 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Nov 19, 6:51 AM UTC: Merged by the Graphite merge queue.

…node session (#4309) resolves #4256 (FR-1448) This PR adds support for selecting multiple agents when launching a session, available for [Backend.AI](http://Backend.AI) manager version 25.15.0 and above. Key changes: - Modified `AgentSelect` component to handle multiple agent selection - Updated agent selection logic in `ResourceAllocationFormItems` to support multi-agent mode - Added special handling for the "auto" option in multi-select mode - Implemented proper agent_list generation in session creation payload - Added 'multi-agents' feature detection for manager version 25.16.0+ - Changed agent default value from string to array format ['auto'] - Removed restrictions that previously disabled cluster settings when a specific agent was selected **for testing, using test server which supports multi node session(like** **dogbowl)** **Prior to version 25.16.0, it must behave identically to the existing version.** how to test: - single mode - Please verify that the agent_list is sent as a string[] when using multi-agents. - multi mode - Please verify that the agent_list is being passed as a string array when using multi-agents. ![CleanShot 2025-09-19 at [email protected]](https://app.graphite.dev/user-attachments/assets/e078b5c2-c9e7-4bb0-b74a-3654f9b22503.png) ![CleanShot 2025-09-19 at [email protected]](https://app.graphite.dev/user-attachments/assets/adcbb2fb-388c-4f98-9d45-161b20e69550.png) ![CleanShot 2025-11-13 at [email protected]](https://app.graphite.com/user-attachments/assets/6dcd76fa-fcc7-4f8c-bfd0-bca9ba34c1a0.png) **Checklist:** - [ ] Documentation - [x] Minium required manager version: 25.16.0 - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

github-actions bot assigned nowgnuesLee Sep 19, 2025

github-actions bot added area:lib Library and SDK related issue. size:M 30~100 LoC labels Sep 19, 2025

nowgnuesLee marked this pull request as ready for review September 19, 2025 08:19

Copilot AI review requested due to automatic review settings September 19, 2025 08:19

nowgnuesLee force-pushed the feat/select-multi-agents branch from 98e011d to 589e38d Compare September 19, 2025 08:20

Copilot AI reviewed Sep 19, 2025

View reviewed changes

react/src/components/AgentSelect.tsx Outdated Show resolved Hide resolved

react/src/pages/SessionLauncherPage.tsx Outdated Show resolved Hide resolved

nowgnuesLee requested review from agatha197, ironAiken2 and yomybaby September 19, 2025 08:28

ironAiken2 requested changes Sep 29, 2025

View reviewed changes

nowgnuesLee force-pushed the feat/select-multi-agents branch from 589e38d to 13c1e92 Compare September 30, 2025 00:03

nowgnuesLee requested a review from ironAiken2 September 30, 2025 00:03

yomybaby reviewed Oct 1, 2025

View reviewed changes

yomybaby force-pushed the feat/select-multi-agents branch 2 times, most recently from a30d7fe to f0ef289 Compare October 1, 2025 06:52

agatha197 requested changes Oct 20, 2025

View reviewed changes

nowgnuesLee force-pushed the feat/select-multi-agents branch from f0ef289 to 9dafe79 Compare November 7, 2025 07:59

github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 7, 2025

nowgnuesLee requested review from agatha197 and yomybaby November 7, 2025 08:13

nowgnuesLee force-pushed the feat/select-multi-agents branch from 9dafe79 to 7b6d945 Compare November 7, 2025 08:14

github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Nov 7, 2025

nowgnuesLee marked this pull request as draft November 10, 2025 05:24

nowgnuesLee force-pushed the feat/select-multi-agents branch from 7b6d945 to 9a85373 Compare November 10, 2025 06:57

nowgnuesLee marked this pull request as ready for review November 10, 2025 07:01

agatha197 requested changes Nov 13, 2025

View reviewed changes

react/src/components/SessionFormItems/ResourceAllocationFormItems.tsx Show resolved Hide resolved

react/src/hooks/useStartSession.tsx Show resolved Hide resolved

nowgnuesLee force-pushed the feat/select-multi-agents branch from 4d0c039 to 5313409 Compare November 13, 2025 01:39

nowgnuesLee requested a review from agatha197 November 13, 2025 04:00

agatha197 requested changes Nov 14, 2025

View reviewed changes

nowgnuesLee force-pushed the feat/select-multi-agents branch from 5313409 to 237e10d Compare November 14, 2025 06:41

github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC and removed size:M 30~100 LoC labels Nov 14, 2025

nowgnuesLee force-pushed the feat/select-multi-agents branch from 237e10d to 9d7f1b2 Compare November 14, 2025 07:25

nowgnuesLee requested a review from agatha197 November 14, 2025 07:26

agatha197 requested changes Nov 18, 2025

View reviewed changes

resources/i18n/ko.json Outdated Show resolved Hide resolved

resources/i18n/ko.json Outdated Show resolved Hide resolved

nowgnuesLee force-pushed the feat/select-multi-agents branch from 9d7f1b2 to 212cf3d Compare November 19, 2025 01:16

nowgnuesLee requested a review from agatha197 November 19, 2025 01:16

agatha197 approved these changes Nov 19, 2025

View reviewed changes

ironAiken2 requested changes Nov 19, 2025

View reviewed changes

react/src/components/AgentSelect.tsx Outdated Show resolved Hide resolved

nowgnuesLee force-pushed the feat/select-multi-agents branch from 212cf3d to 14f370c Compare November 19, 2025 05:47

nowgnuesLee requested review from agatha197 and ironAiken2 November 19, 2025 05:48

yomybaby approved these changes Nov 19, 2025

View reviewed changes

react/src/components/AgentSelect.tsx Outdated Show resolved Hide resolved

ironAiken2 approved these changes Nov 19, 2025

View reviewed changes

yomybaby force-pushed the feat/select-multi-agents branch from 14f370c to 0597693 Compare November 19, 2025 06:49

graphite-app bot force-pushed the feat/select-multi-agents branch from 0597693 to 7ea5f0e Compare November 19, 2025 06:50

graphite-app bot merged commit 7ea5f0e into main Nov 19, 2025
11 checks passed

graphite-app bot deleted the feat/select-multi-agents branch November 19, 2025 06:51

github-pages bot temporarily deployed to github-pages November 19, 2025 06:51 Inactive

github-pages bot temporarily deployed to github-pages November 19, 2025 06:55 Inactive

vercel bot had a problem deploying to Production November 19, 2025 07:36 Failure

feat(FR-1448): allow user to select multi agents when creating multi-node session #4309

feat(FR-1448): allow user to select multi agents when creating multi-node session #4309

Uh oh!

Conversation

nowgnuesLee commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nowgnuesLee commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Code improvements

1. ResourceAllocationFormItems.tsx

2. SessionLauncherPage.tsx

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nowgnuesLee commented Sep 19, 2025 •

edited

Loading

nowgnuesLee commented Sep 19, 2025 •

edited

Loading

github-actions bot commented Sep 19, 2025 •

edited

Loading

Coverage report for `./react`

graphite-app bot commented Nov 19, 2025 •

edited

Loading