feat(FR-1673): implement StartFromURL modal component for repository imports (#4627) #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 49.62% | 132/266 |
| 🔴 | Branches | 29.96% | 80/267 |
| 🔴 | Functions | 33.33% | 20/60 |
| 🔴 | Lines | 51.95% | 120/231 |
Test suite run success
55 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from d6a3d2a
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.73% | 547/11556 |
| 🔴 | Branches | 3.85% | 314/8147 |
| 🔴 | Functions | 2.93% | 104/3554 |
| 🔴 | Lines | 4.68% | 529/11299 |
Test suite run success
125 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from d6a3d2a
yomybaby
force-pushed
the
feat/FR-1673-implement-start-from-url-modal
branch
from
be8c55c to
c6a0f2d
Compare
graphite-app
bot
changed the base branch from
feature/migrate-github-gitlab-import
to
graphite-base/4628
graphite-app
bot
force-pushed
the
feat/FR-1673-implement-start-from-url-modal
branch
from
c6a0f2d to
ae91efc
Compare
graphite-app
bot
force-pushed
the
graphite-base/4628
branch
from
95898aa to
42aaf48
Compare
graphite-app
bot
force-pushed
the
feat/FR-1673-implement-start-from-url-modal
branch
from
ae91efc to
e5564fe
Compare
Merge activity
|
…imports (#4627) (#4628) # Implement Start from URL feature with badge support   This PR adds a new "Start from URL" feature that allows users to import and run notebooks or repositories directly from URLs. It also implements badge support for easy sharing of notebooks and repositories. Key changes: - 🔑 Added a new "Start from URL" card on the Start page - 🔑 Created a unified modal for importing notebooks, GitHub repos, and GitLab repos - 🔑 Implemented support for badge URLs with encoded data parameters - Added backward compatibility for legacy GitHub import URLs - Fixed SVG icon rendering issues for interactive and batch sessions - Removed keyboard trap from modal dialogs for better accessibility **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
bot
force-pushed
the
feat/FR-1673-implement-start-from-url-modal
branch
from
e5564fe to
d6a3d2a
Compare
graphite-app
bot
deleted the
feat/FR-1673-implement-start-from-url-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Start from URL feature with badge support
This PR adds a new "Start from URL" feature that allows users to import and run notebooks or repositories directly from URLs. It also implements badge support for easy sharing of notebooks and repositories.
Key changes:
Checklist: