fix(FR-1686): fix edit button not reappearing after no-change submission in folder name editor #4663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.69% | 547/11673 |
| 🔴 | Branches | 3.82% | 314/8227 |
| 🔴 | Functions | 2.91% | 104/3576 |
| 🔴 | Lines | 4.63% | 529/11414 |
Test suite run success
125 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 3d654df
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the inline edit button for folder names would not reappear after clicking edit and submitting without making changes. The root cause was that the onEditEnd callback was not being invoked when the form was submitted with unchanged values, leaving the parent component's editingColumn state in an inconsistent state.
Key Changes
- Added
onEditEnd?.()callback invocation in the early-return path when folder name hasn't changed
Merge activity
|
…ion in folder name editor (#4663) Resolves #4650 ([FR-1686](https://lablup.atlassian.net/browse/FR-1686)) ## Changes Fixed a bug where the inline edit button (hover edit icon) for folder names would not reappear after: 1. Clicking the edit button to enter edit mode 2. Pressing Enter without making any changes ### Root Cause When the form was submitted with no changes, the `onEditEnd` callback was not being called, leaving the `editingColumn` state in VFolderNodes in an inconsistent state. This prevented the hover edit button from being displayed again. ### Solution Added `onEditEnd?.()` callback invocation in the form submission handler when the folder name hasn't changed, ensuring proper cleanup of the editing state. ## Test Case 1. Navigate to the Data & Storage page 2. Hover over a folder name to see the edit button 3. Click the edit button to enter edit mode 4. Press Enter without making any changes 5. Hover over the folder name again 6. ✅ The edit button should reappear (previously it would not) **Checklist:** - [x] Test case verified: Edit button now reappears correctly after no-change submission [FR-1686]: https://lablup.atlassian.net/browse/FR-1686?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
fix/FR-1686-folder-name-edit-button-reappear
branch
from
cd7fe52 to
3d654df
Compare
graphite-app
bot
deleted the
fix/FR-1686-folder-name-edit-button-reappear
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4650 (FR-1686)
Changes
Fixed a bug where the inline edit button (hover edit icon) for folder names would not reappear after:
Root Cause
When the form was submitted with no changes, the
onEditEndcallback was not being called, leaving theeditingColumnstate in VFolderNodes in an inconsistent state. This prevented the hover edit button from being displayed again.Solution
Added
onEditEnd?.()callback invocation in the form submission handler when the folder name hasn't changed, ensuring proper cleanup of the editing state.Test Case
Checklist: