Skip to content

fix(l1): prevent leak of peer request slots#6517

Closed
iovoid wants to merge 1 commit intomainfrom
snap-drain-inflight-staleness
Closed

fix(l1): prevent leak of peer request slots#6517
iovoid wants to merge 1 commit intomainfrom
snap-drain-inflight-staleness

Conversation

@iovoid
Copy link
Copy Markdown
Contributor

@iovoid iovoid commented Apr 22, 2026

Motivation

Currently we are doing inc_requests manually, but on staleness exit or failure the task that decrements the counter isn't executed.

Description

Before exiting, reap tasks.

@github-actions github-actions Bot added the L1 Ethereum client label Apr 22, 2026
@github-actions
Copy link
Copy Markdown

Lines of code report

Total lines added: 9
Total lines removed: 0
Total lines changed: 9

Detailed view
+------------------------------------------------------+-------+------+
| File                                                 | Lines | Diff |
+------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/snap/client.rs          | 1188  | +7   |
+------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/sync/healing/storage.rs | 619   | +2   |
+------------------------------------------------------+-------+------+

@iovoid
Copy link
Copy Markdown
Contributor Author

iovoid commented Apr 24, 2026

Superceded by #6523

@iovoid iovoid closed this Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant