fix: update entrypoint example deps for Fastify v5 compatibility#456
Open
AaronFeledy wants to merge 2 commits intomainfrom
Open
fix: update entrypoint example deps for Fastify v5 compatibility#456AaronFeledy wants to merge 2 commits intomainfrom
AaronFeledy wants to merge 2 commits intomainfrom
Conversation
Bumps [fastify](https://github.com/fastify/fastify) and [fastify-cli](https://github.com/fastify/fastify-cli). These dependencies needed to be updated together. Updates `fastify` from 4.28.1 to 5.7.4 - [Release notes](https://github.com/fastify/fastify/releases) - [Commits](fastify/fastify@v4.28.1...v5.7.4) Updates `fastify-cli` from 6.3.0 to 7.4.1 - [Release notes](https://github.com/fastify/fastify-cli/releases) - [Commits](fastify/fastify-cli@v6.3.0...v7.4.1) --- updated-dependencies: - dependency-name: fastify dependency-version: 5.7.4 dependency-type: direct:production - dependency-name: fastify-cli dependency-version: 7.4.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
❌ Deploy Preview for lando-core failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #426.
Dependabot bumped
fastifyto ^5.7.4 andfastify-clito ^7.4.1, but left the other Fastify ecosystem deps on v4-era versions, causing the entrypoint container to crash on start.This PR includes the Dependabot changes plus updates all Fastify deps to be v5 compatible:
@fastify/autoload: ^5 → ^6@fastify/sensible: ^5 → ^6fastify-plugin: ^4 → ^5App code was verified — no Fastify v5 code changes needed. Smoke tested all routes successfully.
Closes #426
Note
Medium Risk
Major-version dependency upgrades (Fastify v4→v5, CLI/plugins) can introduce runtime breakage and stricter Node engine requirements via transitive deps. Risk is limited to the
examples/entrypointsample, but could still affect users relying on the example container/image.Overview
Updates
examples/entrypointto be Fastify v5 compatible by bumpingfastify,fastify-cli,@fastify/autoload,@fastify/sensible, andfastify-pluginto their corresponding major versions.Regenerates
package-lock.jsonto reflect the new dependency graph, including updated/transitively added packages and newer Node engine constraints pulled in by Fastify v5-era dependencies.Reviewed by Cursor Bugbot for commit f70538a. Bugbot is set up for automated code reviews on this repo. Configure here.