fix: update Node engine floor for major npm dep bumps#457
Open
AaronFeledy wants to merge 2 commits intomainfrom
Open
fix: update Node engine floor for major npm dep bumps#457AaronFeledy wants to merge 2 commits intomainfrom
AaronFeledy wants to merge 2 commits intomainfrom
Conversation
Bumps [tar](https://github.com/isaacs/node-tar) to 7.5.9 and updates ancestor dependencies [tar](https://github.com/isaacs/node-tar), [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist), [npm-profile](https://github.com/npm/npm-profile) and [pacote](https://github.com/npm/pacote). These dependencies need to be updated together. Updates `tar` from 6.2.1 to 7.5.9 - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.2.1...v7.5.9) Updates `@npmcli/arborist` from 6.5.1 to 9.3.0 - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/v9.3.0/workspaces/arborist) Updates `npm-profile` from 9.0.2 to 12.0.1 - [Release notes](https://github.com/npm/npm-profile/releases) - [Changelog](https://github.com/npm/npm-profile/blob/main/CHANGELOG.md) - [Commits](npm/npm-profile@v9.0.2...v12.0.1) Updates `pacote` from 15.2.0 to 21.3.1 - [Release notes](https://github.com/npm/pacote/releases) - [Changelog](https://github.com/npm/pacote/blob/main/CHANGELOG.md) - [Commits](npm/pacote@v15.2.0...v21.3.1) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.9 dependency-type: indirect - dependency-name: "@npmcli/arborist" dependency-version: 9.3.0 dependency-type: direct:production - dependency-name: npm-profile dependency-version: 12.0.1 dependency-type: direct:production - dependency-name: pacote dependency-version: 21.3.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
❌ Deploy Preview for lando-core failed. Why did it fail? →
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #433.
Dependabot bumped
tar(^6→^7),@npmcli/arborist(^6→^9),npm-profile(^9→^12), andpacote(^15→^21).Findings:
@npmcli/arborist,npm-profile, andpacotenow require Node^20.17.0 || >=22.9.0, which is stricter than the repo's previous>=20.0.0Changes:
package.json:engines.nodefrom>=20.0.0to>=20.17.0.node-version:20to20.17.0package-lock.jsonNote on CI orchestrator failure: The
client version 1.43 is too olderror is a Docker API version mismatch in the CI environment, unrelated to these dep bumps.All 195 unit tests passing locally.
Closes #433
Note
Low Risk
Low risk change that only adjusts the declared Node.js version, with no runtime or business-logic modifications.
Overview
Updates the repository’s Node.js version pin by changing
.node-versionfrom20to20.17.0, aligning local/dev tooling on the newer Node 20 floor.Reviewed by Cursor Bugbot for commit 8e81431. Bugbot is set up for automated code reviews on this repo. Configure here.