This repository was archived by the owner on Nov 12, 2026. It is now read-only.
Repository navigation
perf(runtime): dispatch ordered installation event batches - #194
Merged
Merged
Conversation
This was referenced Oct 26, 2026
huanghuoguoguo
force-pushed
the
perf/runtime-batched-events-2710
branch
from
October 26, 2026 13:09
2003602 to
d752915
Compare
huanghuoguoguo
marked this pull request as ready for review
October 27, 2026 03:20
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Advertise event_batch in the existing SET_RUNTIME_CONFIG response and accept an ordered installation list in EMIT_EVENT. Validate the complete list before effects and revalidate each binding immediately before dispatch. Reject cross-Workspace/generation, duplicate, mismatched envelope and stale installation bindings.
Keep per-installation context task-local, restore it in finally, and preserve serial event mutation, attribution and stop propagation. Single-installation requests remain supported. The original envelope continues to own the transport action task.
Related: langbot-app/LangBot#2710. This is the Runtime half; the companion Core PR supplies the negotiated batch. Release/deployment is a separate step.
Validation
On this independently split branch:
pytest tests/runtime/io/handlers/test_control_handler.py tests/runtime/plugin/test_event_dispatch_real_worker.py -q: 61 passed, including real per-plugin stdio workers with nsjail unavailable, context mutation, stop propagation and binding rejection. Shared-profile admission is covered by the control-handler tests; this does not claim an OS sandbox integration test.Combined Core/Runtime diagnostics reduced 20 to 5 event RPCs per measured Pipeline request. Overall throughput and tail latency are not guaranteed by that count reduction. Draft pending review and remaining performance acceptance.
Related review pieces