-
Notifications
You must be signed in to change notification settings - Fork 18.3k
chore: add type-check to pre-commit #28005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add type-check to pre-commit #28005
Conversation
Summary of ChangesHello @lyzno1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the development workflow by adding a TypeScript type-checking step to the pre-commit hook for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a TypeScript type-checking step to the pre-commit hook for the web frontend. This is a great addition for maintaining code quality. My review includes a suggestion to optimize this new step by only running it when TypeScript files have actually been modified, which will improve the pre-commit hook's performance.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a TypeScript type-checking step to the pre-commit hook, which is a great improvement for code quality. The check is smartly conditioned to run only when TypeScript files are staged, which is efficient. My review includes a minor suggestion to make the shell script logic more concise and idiomatic.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a TypeScript type-checking step to the pre-commit hook. The implementation correctly checks for staged TypeScript files before running the type check. My feedback includes a suggestion to refactor a portion of the shell script to improve readability and maintainability by using a case statement, which is a more idiomatic way to handle different exit codes from the git diff command.
Important
Fixes #<issue number>.Summary
Screenshots
Checklist
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods