Skip to content

edits to rproc heating source#18

Draft
Adithan25 wants to merge 1 commit intolanl:mainfrom
Adithan25:edits
Draft

edits to rproc heating source#18
Adithan25 wants to merge 1 commit intolanl:mainfrom
Adithan25:edits

Conversation

@Adithan25
Copy link
Copy Markdown
Contributor

Background

  • Adjusting SOURCE files to try and get consistent heating rate between tabular and rproc source

Changes

  • SOURCE files (need to be compared)

Merge Requirements

  • Verify compilation.
  • No "Draft" designation.
  • Approved by a reviewer.

Comment thread #supernu.f90#
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an unsaved file checkpoint that got git added - is this supposed to be here?

real*8, parameter :: X_beta = 0.20d0
real*8, parameter :: X_gamma = 0.35d0
real*8, parameter :: X_ff = 0.00d0
real*8, parameter :: ye_w = 0.37d0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this separate Ye approach is important, we'll have to add an extra column in input.str to set these per ejecta component.

Comment thread Testsuite/first/input.par
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this input doesn't relate to the problem, was it accidentally deleted?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was due to the data corruption stuff that occurred in Chicoma where a bunch of files got deleted.

@RyanWollaeger RyanWollaeger marked this pull request as draft October 17, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants