Merged
Conversation
Collaborator
Author
|
jaybenne fails to compile because it is looking for |
pdmullen
approved these changes
Jan 14, 2025
Collaborator
|
Totally fine with bumping singularity version here, but I think there is some confusion about what singularity provides and what we want (i.e., |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
So that we can use
MeanAtomicMass()to pull outmuwithout having to pass it andamuto functions we are already passing the eos to.I also want to see if
jaybennewill build properly...because I'm having problems on another branch when updating singularity.Description of Changes
Checklist