Special case pointer up on view check #846
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a view has clicking set on it and it receives a pointer up event, it should be "on" the view if either the transformed event is in the view or if the untransformed event is in the view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a view has clicking set on it and it receives a pointer up event, it should be "on" the view if either the transformed event is in the view or if the untransformed event is in the view
We should probably go through and have methods for getting the view's rect/size from layout and have methods for getting the view visual rect/size after transforms. Naming these and having it be consistent and removing the methods that return taffy layout types would probably make things easier