[13.x] Support Guzzle 8 and persistent connections across php-fpm requests - #60321
Open
GrahamCampbell wants to merge 2 commits into
Open
[13.x] Support Guzzle 8 and persistent connections across php-fpm requests#60321GrahamCampbell wants to merge 2 commits into
GrahamCampbell wants to merge 2 commits into
Conversation
GrahamCampbell
force-pushed
the
guzzle-8
branch
2 times, most recently
from
July 12, 2026 11:29
2f8a29c to
a0ee337
Compare
GrahamCampbell
force-pushed
the
guzzle-8
branch
2 times, most recently
from
July 26, 2026 22:30
44a9b08 to
e57fb66
Compare
GrahamCampbell
marked this pull request as ready for review
July 26, 2026 22:37
GrahamCampbell
commented
Jul 26, 2026
| * | ||
| * @param \Psr\Http\Message\StreamInterface|array|string|resource|null $body | ||
| * @param int $status | ||
| * @param array<string, mixed> $headers |
Collaborator
Author
There was a problem hiding this comment.
Header names might not be strings because PHP forces numeric strings to ints, to array aka array<array-key, mixed> really is the right type here!
Collaborator
Author
|
Rebased to get a clean CI run. Guzzle 7 gets exercised by the prefer lowest tests, and Guzzle 8 by the rest. |
1 task
mokuzon
added a commit
to line/line-bot-sdk-php
that referenced
this pull request
Jul 28, 2026
The main test matrix always resolves to Guzzle 7 because laravel/framework (via orchestra/testbench) does not allow Guzzle 8 yet, so the widened guzzle constraint was not exercised by CI at all. Add a job that drops the Laravel-only dev dependency and runs the framework-agnostic test suites (Parser and Test, which cover the generated API clients) against Guzzle 8. This mirrors the only real-world Guzzle 8 setup: non-Laravel applications, since Laravel apps cannot install Guzzle 8 in the first place. Declare mockery/mockery explicitly in require-dev; the client tests use it directly but previously received it transitively from orchestra/testbench, which this job removes. This job can be deleted once laravel/framework allows guzzle ^8.0 (laravel/framework#60321) and the main matrix picks up Guzzle 8 natively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Guzzle 8, while maintaining Guzzle 7 support. Guzzle 8 comes with a significant new feature: PHP 8.5+ users with ext-curl installed can have connections shared across php-fpm requests. I've implemented this with the following DX:
The
PersistentTransportsurfaces 3 options:None: Do not try and share connections. This is the current behaviour, and remains the default.Preferred: Try to share connections, but if we are not able to, silently fallback.Required: Try to share connections, and if we are not able to, fail loud.