[13.x] Apply Rector rules (remove low-impact rules)

rector.php

@@ -5,31 +5,22 @@
 use Rector\CodeQuality\Rector\FuncCall\CompactToVariablesRector;
 use Rector\CodeQuality\Rector\FuncCall\SortCallLikeNamedArgsRector;
 use Rector\CodeQuality\Rector\Identical\StrlenZeroToIdenticalEmptyStringRector;
-use Rector\CodingStyle\Rector\ArrowFunction\ArrowFunctionDelegatingCallToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\Closure\ClosureDelegatingCallToFirstClassCallableRector;
-use Rector\CodingStyle\Rector\FuncCall\ClosureFromCallableToFirstClassCallableRector;
 use Rector\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector;
-use Rector\CodingStyle\Rector\FuncCall\FunctionFirstClassCallableRector;
 use Rector\Config\RectorConfig;
 use Rector\Php55\Rector\Class_\ClassConstantToSelfClassRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
-use Rector\Php56\Rector\FuncCall\PowToExpRector;
 use Rector\Php70\Rector\FuncCall\RandomFunctionRector;
-use Rector\Php70\Rector\MethodCall\ThisCallOnStaticMethodToStaticCallRector;
 use Rector\Php70\Rector\Ternary\TernaryToNullCoalescingRector;
 use Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector;
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
 use Rector\Php74\Rector\Closure\ClosureToArrowFunctionRector;
 use Rector\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector;
 use Rector\Php80\Rector\Class_\StringableForToStringRector;
-use Rector\Php80\Rector\ClassConstFetch\ClassOnThisVariableObjectRector;
 use Rector\Php80\Rector\FuncCall\ClassOnObjectRector;
-use Rector\Php80\Rector\Switch_\ChangeSwitchToMatchRector;
-use Rector\Php80\Rector\Ternary\GetDebugTypeRector;
 use Rector\Php81\Rector\Array_\ArrayToFirstClassCallableRector;
 use Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector;
 use Rector\Php81\Rector\Property\ReadOnlyPropertyRector;
-use Rector\Php82\Rector\Class_\ReadOnlyClassRector;
 use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
 use Rector\Php83\Rector\ClassMethod\AddOverrideAttributeToOverriddenMethodsRector;
 use Rector\Php83\Rector\FuncCall\DynamicClassConstFetchRector;
@@ -95,31 +86,22 @@
         AddOverrideAttributeToOverriddenMethodsRector::class,
         AddTypeToConstRector::class,
         ArrayToFirstClassCallableRector::class,
-        ArrowFunctionDelegatingCallToFirstClassCallableRector::class,
         BinaryOpBetweenNumberAndStringRector::class,
-        ChangeSwitchToMatchRector::class,
         ClassConstantToSelfClassRector::class,
         ClassOnObjectRector::class,
-        ClassOnThisVariableObjectRector::class,
         ClassPropertyAssignToConstructorPromotionRector::class,
         ClosureDelegatingCallToFirstClassCallableRector::class,
-        ClosureFromCallableToFirstClassCallableRector::class,
         ClosureToArrowFunctionRector::class,
         DeprecatedAnnotationToDeprecatedAttributeRector::class,
         DynamicClassConstFetchRector::class,
-        FunctionFirstClassCallableRector::class,
-        GetDebugTypeRector::class,
         NullToStrictStringFuncCallArgRector::class,
-        PowToExpRector::class,
         RandomFunctionRector::class,
-        ReadOnlyClassRector::class,
         ReadOnlyPropertyRector::class,
         RemoveExtraParametersRector::class,
         ReturnNeverTypeRector::class,
         StringClassNameToClassConstantRector::class,
         StringableForToStringRector::class,
         TernaryToNullCoalescingRector::class,
-        ThisCallOnStaticMethodToStaticCallRector::class,
         'tests/Foundation/fixtures/bad-syntax-strategy.php',
     ])
     ->withRules([

src/Illuminate/Collections/Collection.php

@@ -1881,7 +1881,7 @@ public function values()
      */
     public function zip($items)
     {
-        $arrayableItems = array_map(fn ($items) => $this->getArrayableItems($items), func_get_args());
+        $arrayableItems = array_map($this->getArrayableItems(...), func_get_args());
 
         $params = array_merge([fn () => $this->newInstance(func_get_args()), $this->items], $arrayableItems);
 

src/Illuminate/Collections/Traits/EnumeratesValues.php

@@ -1148,7 +1148,7 @@ protected function operatorForWhere($key, $operator = null, $value = null)
                 };
             });
 
-            if (count($strings) < 2 && count(array_filter([$retrieved, $value], 'is_object')) == 1) {
+            if (count($strings) < 2 && count(array_filter([$retrieved, $value], is_object(...))) == 1) {
                 return in_array($operator, ['!=', '<>', '!==']);
             }
 

src/Illuminate/Database/Eloquent/Model.php

@@ -1976,7 +1976,7 @@ public function hasNamedScope($scope)
      */
     public function callNamedScope($scope, array $parameters = [])
     {
-        if ($this->isScopeMethodWithAttribute($scope)) {
+        if (static::isScopeMethodWithAttribute($scope)) {
             return $this->{$scope}(...$parameters);
         }
 

src/Illuminate/Database/Query/Builder.php

@@ -4566,7 +4566,7 @@ protected function forSubQuery()
     public function getColumns()
     {
         return ! is_null($this->columns)
-            ? array_map(fn ($column) => $this->grammar->getValue($column), $this->columns)
+            ? array_map($this->grammar->getValue(...), $this->columns)
             : [];
     }
 

src/Illuminate/Database/Query/Grammars/MySqlGrammar.php

@@ -146,7 +146,7 @@ protected function compileIndexHint(Builder $query, $indexHint)
     {
         $index = $indexHint->index;
 
-        $indexes = array_map('trim', explode(',', $index));
+        $indexes = array_map(trim(...), explode(',', $index));
 
         foreach ($indexes as $i) {
             if (! preg_match('/^[a-zA-Z0-9_$]+$/', $i)) {

src/Illuminate/Database/Query/Grammars/PostgresGrammar.php

@@ -851,7 +851,7 @@ public function getOperators()
     public static function customOperators(array $operators)
     {
         static::$customOperators = array_values(
-            array_merge(static::$customOperators, array_filter(array_filter($operators, 'is_string')))
+            array_merge(static::$customOperators, array_filter(array_filter($operators, is_string(...))))
         );
     }
 

src/Illuminate/Http/Client/PendingRequest.php

@@ -1564,7 +1564,7 @@ protected function normalizeMultipartHeaders(array $multipart): array
     protected function normalizeRequestOptionValue($value)
     {
         return match (true) {
-            is_array($value) => array_map(fn ($item) => $this->normalizeRequestOptionValue($item), $value),
+            is_array($value) => array_map($this->normalizeRequestOptionValue(...), $value),
             $value instanceof Stringable => $value->toString(),
             default => $value,
         };

src/Illuminate/Http/Resources/JsonApi/Exceptions/ResourceIdentificationException.php

@@ -14,7 +14,7 @@ class ResourceIdentificationException extends RuntimeException
      */
     public static function attemptingToDetermineIdFor($resource)
     {
-        $resourceType = is_object($resource) ? $resource::class : gettype($resource);
+        $resourceType = get_debug_type($resource);
 
         return new self(sprintf(
             'Unable to resolve resource object ID for [%s].', $resourceType
@@ -29,7 +29,7 @@ public static function attemptingToDetermineIdFor($resource)
      */
     public static function attemptingToDetermineTypeFor($resource)
     {
-        $resourceType = is_object($resource) ? $resource::class : gettype($resource);
+        $resourceType = get_debug_type($resource);
 
         return new self(sprintf(
             'Unable to resolve resource object type for [%s].', $resourceType

src/Illuminate/JsonSchema/Deserializer.php

@@ -166,7 +166,7 @@ protected function buildObject(array $schema, array $refs = []): Types\ObjectTyp
 
         if (isset($schema['properties']) && is_array($schema['properties'])) {
             $required = is_array($schema['required'] ?? null)
-                ? array_flip(array_map('strval', $schema['required']))
+                ? array_flip(array_map(strval(...), $schema['required']))
                 : [];
 
             foreach ($schema['properties'] as $key => $definition) {
@@ -356,7 +356,7 @@ protected function resolveType(array $schema): array
         if (is_array($type)) {
             $nullable = in_array('null', $type, true);
 
-            $names = array_values(array_unique(array_map('strval', array_filter(
+            $names = array_values(array_unique(array_map(strval(...), array_filter(
                 $type,
                 static fn ($value) => $value !== 'null',
             ))));

src/Illuminate/JsonSchema/Serializer.php

@@ -27,7 +27,7 @@ public static function serialize(Types\Type $type): array
 
         if ($type instanceof Types\AnyOfType) {
             $attributes['anyOf'] = array_map(
-                static fn (Types\Type $schema) => static::serialize($schema),
+                static::serialize(...),
                 $attributes['schemas'],
             );
 
@@ -80,10 +80,10 @@ public static function serialize(Types\Type $type): array
                 unset($attributes['properties']);
             } else {
                 $required = array_map(
-                    'strval',
+                    strval(...),
                     array_keys(array_filter(
                         $attributes['properties'],
-                        static fn (Types\Type $property) => static::isRequired($property),
+                        static::isRequired(...),
                     ))
                 );
 
@@ -92,7 +92,7 @@ public static function serialize(Types\Type $type): array
                 }
 
                 $attributes['properties'] = array_map(
-                    static fn (Types\Type $property) => static::serialize($property),
+                    static::serialize(...),
                     $attributes['properties'],
                 );
             }

src/Illuminate/JsonSchema/Types/UnionType.php

@@ -29,7 +29,7 @@ class UnionType extends Type
      */
     public function __construct(array $types)
     {
-        $names = array_map('strval', $types);
+        $names = array_map(strval(...), $types);
 
         if (in_array('null', $names, true)) {
             $this->nullable();

src/Illuminate/Mail/Message.php

@@ -290,7 +290,7 @@ protected function ensureAddressIsSafe($address)
      */
     protected function ensureAddressesAreSafe(array $addresses)
     {
-        return array_map(fn ($address) => $this->ensureAddressIsSafe($address), $addresses);
+        return array_map($this->ensureAddressIsSafe(...), $addresses);
     }
 
     /**

src/Illuminate/Routing/RouteSignatureParameters.php

@@ -34,7 +34,7 @@ public static function fromAction(array $action, $conditions = [])
 
         return match (true) {
             ! empty($conditions['subClass']) => array_filter($parameters, fn ($p) => Reflector::isParameterSubclassOf($p, $conditions['subClass'])),
-            ! empty($conditions['backedEnum']) => array_filter($parameters, fn ($p) => Reflector::isParameterBackedEnumWithStringBackingType($p)),
+            ! empty($conditions['backedEnum']) => array_filter($parameters, Reflector::isParameterBackedEnumWithStringBackingType(...)),
             default => $parameters,
         };
     }

src/Illuminate/Routing/RouteUrlGenerator.php

@@ -431,7 +431,7 @@ protected function getRouteQueryString(array $parameters)
      */
     protected function getStringParameters(array $parameters)
     {
-        return array_filter($parameters, 'is_string', ARRAY_FILTER_USE_KEY);
+        return array_filter($parameters, is_string(...), ARRAY_FILTER_USE_KEY);
     }
 
     /**
@@ -442,7 +442,7 @@ protected function getStringParameters(array $parameters)
      */
     protected function getNumericParameters(array $parameters)
     {
-        return array_filter($parameters, 'is_numeric', ARRAY_FILTER_USE_KEY);
+        return array_filter($parameters, is_numeric(...), ARRAY_FILTER_USE_KEY);
     }
 
     /**

src/Illuminate/Routing/UrlGenerator.php

@@ -223,7 +223,7 @@ public function to($path, $extra = [], $secure = null)
         }
 
         $tail = implode('/', array_map(
-            'rawurlencode', (array) $this->formatParameters($extra))
+            rawurlencode(...), (array) $this->formatParameters($extra))
         );
 
         // Once we have the scheme we will compile the "tail" by collapsing the values

src/Illuminate/Support/Number.php

@@ -297,7 +297,7 @@ protected static function summarize(int|float $number, int $precision = 0, ?int
 
         $numberExponent = floor(log10($number));
         $displayExponent = $numberExponent - ($numberExponent % 3);
-        $number /= pow(10, $displayExponent);
+        $number /= 10 ** $displayExponent;
 
         $formatted = static::format($number, $precision, $maxPrecision);
 

src/Illuminate/Support/Str.php

@@ -1755,7 +1755,7 @@ public static function studly($value, bool $normalize = false)
 
         $words = preg_split('/\s+/u', static::replace(['-', '_'], ' ', $value), -1, PREG_SPLIT_NO_EMPTY);
 
-        $studlyWords = array_map(fn ($word) => static::ucfirst($word), $words);
+        $studlyWords = array_map(static::ucfirst(...), $words);
 
         return static::$studlyCache[$key] = implode('', $studlyWords);
     }