[13.x] Fix Collection::mode() returning wrong results for float values#60721
Open
Amirhf1 wants to merge 1 commit into
Open
[13.x] Fix Collection::mode() returning wrong results for float values#60721Amirhf1 wants to merge 1 commit into
Amirhf1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection::mode()(andLazyCollection::mode(), which just delegates to it) gives you the wrong answer when your collection has float values in it.Why
The method counts occurrences by using each value directly as an array key:
The problem is PHP silently truncates float array keys down to integers. So if you have distinct floats that happen to share the same integer part, they get lumped together into one bucket: