[13.x] Implement creationTimeOfOldestPendingJob on the QueueFake#60730
Draft
jackbayliss wants to merge 2 commits into
Draft
[13.x] Implement creationTimeOfOldestPendingJob on the QueueFake#60730jackbayliss wants to merge 2 commits into
creationTimeOfOldestPendingJob on the QueueFake#60730jackbayliss wants to merge 2 commits into
Conversation
jackbayliss
changed the title
creationTimeOfOldestPendingJob on the QueueFakecreationTimeOfOldestPendingJob on the QueueFake
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bothered me as it was the only method still stubbed.
The PR ensures
creationTimeOfOldestPendingJobworks on the fake, and we now also ensure all theInspectedJobclasses have a createdAt set, which is what would happen on the real drivers, which again is nice if you're using any of the methods and diving into the classes!This now means, all the queue metrics/inspection methods are covered by the fake 🥳 🥳 🥳 🥳 🥳