Skip to content

Resolves LAT-TUA1: skip user-centric flaggers on signal-details dogfood traces - #4378

Open
geclos wants to merge 1 commit into
developmentfrom
cursor/contradictory-platform-guidance-4e5f
Open

Resolves LAT-TUA1: skip user-centric flaggers on signal-details dogfood traces#4378
geclos wants to merge 1 commit into
developmentfrom
cursor/contradictory-platform-guidance-4e5f

Conversation

@geclos

@geclos geclos commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Resolves LAT-TUA1

Fixes a false-positive signal in the internal Signal Discovery dogfood project: Contradictory platform guidance causes user confusion.

The flagged trace (d485c729427aae2d8af55e389a697aa5, tag issue:details) is Latitude's own signal-details generation (generateSignalDetailsUseCase). Its user-role prompt embeds occurrence feedback that quotes end users of another organization ("kazales uzywac shopify jako miejsce edycji a teraz mowisz ze w mc", "I am just going to pay someone to do this", etc.). The user-centric frustration flagger ran on that dogfood session and read the quoted complaints as real user frustration, raising a signal about a "contradictory platform guidance" problem that does not exist in the trace being scored — it belongs to the customer conversations quoted inside the prompt.

The repo already has a guard for exactly this failure mode: isUserCentricReflagInapplicable drops user/input-centric strategies (frustration, jailbreaking, nsfw) on sessions whose tags mark the user-role text as nested conversation samples. The list covered flagger classify/draft and taxonomy tags but not issue:details. This PR adds AI_GENERATE_TELEMETRY_TAGS.signalDetails to NESTED_CONVERSATION_SAMPLE_TAGS, so signal-details generations keep assistant-response-centric flagging (self-observability of the naming output) while no longer being misread by user-centric flaggers.

Also updates dev-docs/flaggers.md to list the new tag in the self-observability section.

Related issue (if applicable)

Latitude signal LAT-TUA1 (ID pdyowwdmxpdqc4lrgzyjukhd).

How was this tested?

  • New regression test in packages/domain/flaggers/src/reflag.test.ts: issue:details tags skip user-centric strategies while assistant-response-centric strategies still run.
  • pnpm --filter @domain/flaggers test — 346 passed, 2 skipped.
  • pnpm --filter @domain/flaggers typecheck — clean.
  • biome check on the touched files — clean.

Checklist

  • Lint, type-checking, and tests pass locally
  • PR title follows Conventional Commits
  • I have signed the CLA
Open in Web Open in Cursor 

Summary by CodeRabbit

  • Bug Fixes

    • Improved signal-details processing by skipping user-centric feedback checks when occurrence feedback is unavailable.
    • Preserved user-centric reflagging when occurrence feedback is present.
    • Ensured assistant-response strategies continue to run in supported signal-details contexts.
  • Tests

    • Added coverage for signal-details scenarios with and without occurrence feedback.

…races

The signal-details generation (issue:details) embeds occurrence feedback
quoting end users in its user-role prompt, so the frustration flagger read
the quoted complaints as real user frustration and raised a false signal in
the Signal Discovery dogfood project (LAT-TUA1). Add the tag to the
nested-conversation-sample list so user/input-centric strategies skip
those sessions, matching the existing flagger and taxonomy handling.

Co-authored-by: Gerard <gerard@latitude.so>
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Ready Ready Preview Aug 6, 2026 9:17pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a50e6108-530d-4e3e-99dc-ecec149c803a

📥 Commits

Reviewing files that changed from the base of the PR and between 03cce03 and bb35463.

📒 Files selected for processing (3)
  • dev-docs/flaggers.md
  • packages/domain/flaggers/src/reflag.test.ts
  • packages/domain/flaggers/src/reflag.ts

📝 Walkthrough

Walkthrough

Signal-details telemetry tags are now treated as nested conversation samples. User-centric reflagging is skipped without occurrence feedback and remains applicable when occurrence feedback is enabled. Tests and flagger documentation cover this behavior.

Changes

Flagger reflagging

Layer / File(s) Summary
Signal-details suppression and coverage
packages/domain/flaggers/src/reflag.ts, packages/domain/flaggers/src/reflag.test.ts, dev-docs/flaggers.md
Signal-details tags are included in nested conversation sample detection. Tests and documentation cover suppression without occurrence feedback and applicability with occurrence feedback.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the issue and the main change: skipping user-centric flaggers on signal-details dogfood traces.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/contradictory-platform-guidance-4e5f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@geclos
geclos marked this pull request as ready for review August 10, 2026 07:41
@claude

claude Bot commented Aug 10, 2026

Copy link
Copy Markdown

📄 Generated a rich HTML walkthrough of this PR's diff against development (background, intuition, code walkthrough, and a 5-question quiz).

Artifact: https://artifact-pr-4378-diff-review.nostalgic-keyboard.workers.dev

Claim within 60 minutes (permanent link): https://dash.cloudflare.com/claim-preview?claimToken=wHKGSa7HOTDve69WxvteteJ8ucJHB1gM1QumM4cpDtI

Self-contained artifact, no external requests. Generated by an automated agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

3 participants