chore: adopt bambamboole/extended-testbench 0.6.1 - #17
Merged
Conversation
0.6.1 adds a `package:init --check` drift gate, so the alignment is now verifiable instead of hand-diffed. Wired it into CI. - pint.json restores blank_line_after_opening_tag: false — upstream reverted that rule, so the scaffold no longer enforces the blank line. Disabling it only stops pint enforcing the blank line, it does not strip the ones the previous stub introduced, so those are removed here directly: back to `<?php` immediately followed by `declare(strict_types=1);`. - test -> pest --exclude-testsuite=Browser. Enumerating Unit,Feature would silently drop the new Arch suite. - New Arch suite (tests/ArchTest.php): no debug statements, strict types across Lattice\Media. - phpunit.xml.dist pins Testbench's APP_KEY fixture; package:purge-skeleton deletes the .env that otherwise carries it. - boost:refresh defers while package.json sits next to a missing node_modules, since Boost discovers frontend packages through the installed tree. - .gitignore picks up /.codex/. Two divergences are baselined in extra.extended-testbench.check-ignore: tests/Browser/DummyTest.php, because the scaffold's placeholder test is redundant next to the three real browser tests, and rector.php, which keeps the FlipTypeControlToUseExclusiveTypeRector skip upstream did not take. The drift gate needs the explicit section flags — a bare --check falls back to the prompt defaults rather than inferring the sections from the repo, and reports a package that has browser tests and a workbench as drifted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
bambamboole/extended-testbench0.3.0 → 0.6.1 and adopts what its newpackage:init --checkdrift gate reports. That gate is now wired into CI, so this alignment is verifiable instead of hand-diffed.Adopted
test→pest --exclude-testsuite=Browser. EnumeratingUnit,Featurewould silently drop the new Arch suite.tests/ArchTest.php): no debug statements ship, strict types acrossLattice\Media.phpunit.xml.distpins Testbench'sAPP_KEYfixture —package:purge-skeletondeletes the.envthat otherwise carries it, which is what makes a cold suite throwMissingAppKeyException.boost:refreshnow defers whilepackage.jsonsits next to a missingnode_modules; Boost discovers frontend packages through the installed tree, so refreshing early drops their skills..gitignorepicks up/.codex/.Pint reversal. Upstream reverted the
blank_line_after_opening_tagrule, sopint.jsongoes back to disabling it — undoing that part of #16. Disabling only stops Pint enforcing the blank line; it does not strip the ones the 0.3.0 stub introduced, so those are removed directly here (70 files, one line each). Back to<?phpimmediately followed bydeclare(strict_types=1);.Baselined divergences in
extra.extended-testbench.check-ignore:tests/Browser/DummyTest.php— the scaffold's placeholder is redundant next to the three real browser tests.rector.php— keeps theFlipTypeControlToUseExclusiveTypeRectorskip upstream didn't take.Note on the CI gate: it needs the explicit section flags. A bare
--checkfalls back to the prompt defaults rather than inferring sections from the repo, so it reports a package that has browser tests and a workbench as drifted.Verified:
composer check(Pint, PHPStan, Rector, 145 Pest incl. Arch),package:init --check(no drift),composer test:browser(9),npm run typecheck && npm test(39).