Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
4b3ecc3 to
4c90a3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add in the renderer implementation. There is an example of how this is used in https://github.com/launchdarkly/js-core/tree/skz/electron-sdk-next/packages/sdk/electron/example
Note
Medium Risk
Touches cross-process IPC wiring and event subscription lifecycle/cleanup; failures could cause leaked ports/listeners or missing renderer updates, though coverage is strong and changes are largely additive.
Overview
Adds a full renderer-to-main IPC bridge for the Electron SDK. The main-process
ElectronClientnow registersipcMainhandlers for all flag/identify/flush/connection-mode APIs and supports renderer event subscriptions viaMessagePortbroadcasting, including cleanup onclose()and a guard for add/remove ordering races.Introduces the preload bridge (
src/bridge) that exposeswindow.ldClientBridgeand a new renderer client (createRendererClient/ElectronRendererClient) that delegates all calls over IPC and implements handle-basedon()/off()subscription management with automatic teardown onclose().Includes small robustness/docs updates (safer
ElectronDataManagerstart, typo fixes, updated IPC docs) and adds comprehensive Jest tests covering IPC calls, event subscription behavior, and resource cleanup.Written by Cursor Bugbot for commit c552382. This will update automatically on new commits. Configure here.