Repository navigation
Note Math: add accidentals, randomized spellings, interval accidentals, and virtual MIDI keyboard - #182
Open
Naphier wants to merge 10 commits into
Open
Note Math: add accidentals, randomized spellings, interval accidentals, and virtual MIDI keyboard#182Naphier wants to merge 10 commits into
Naphier wants to merge 10 commits into
Conversation
…s, and virtual MIDI keyboard - Merge pull request #1 from Naphier/codex/add-accidentals-and-virtual-midi-keyboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
static/js/st/components/flash_cards/note_math_exercise.jsxthat introduces settings forincidentals,randomizeAccidentals(b/#),intervalAccidentals, andvirtualMidiKeyboard, and retains the original natural-only behavior whenincidentalsis off.Keyboardcomponent as an optional virtual piano that replaces the note-button row whenvirtualMidiKeyboardis enabled and maps piano key presses to enharmonic pitch-class answers.static/js/st/components/flash_cards/flash_cards.module.cssto support disabled toggle styling and fixed-bottom keyboard layout.Testing
npx eslint static/js/st/components/flash_cards/note_math_exercise.jsx— succeeded.mkdir -p dev/out && npm run --silent note_math_csv > dev/out/note-math.csv- verification:npm run build_assets— succeeded and generated the frontend assets used by the dev server.git diff --check— succeeded with no trailing whitespace or conflict markers.http://127.0.0.1:3000/flash-cards/note-mathwhich returned HTML successfully.Codex Task